Async is supported - Githubissues

MaxOhn / rosu-pp

PP and star calculation for all osu! gamemodes

MIT License

85 stars 40 forks source link

Async is supported #1

Closed Pure-Peace closed 3 years ago

Pure-Peace commented 3 years ago

PR - rosu-pp v0.1.2

Suppot asynchronous beatmap file reading and parsing (based on async-std).
New features "async_std" (optional).
Add an asynchronous wrapper for calculate(): calculate_async().
Add asynchronous testing.
README.md added async examples.
Change the version number to 0.1.2.
Added async keywords in Cargo.toml

MaxOhn commented 3 years ago

Thanks for the PR! Looks pretty good. I think the code duplication can be reduced a little through some #[cfg]s but I'll look into it. Merging it right up :)

FYI I want to keep the main branch in sync with the version on crates.io so the new stuff goes into the next branch but you couldn't know that so no condemning here.

Pure-Peace commented 3 years ago

Oh, I agree with you. Really good project! :D

MaxOhn commented 3 years ago

Small update:

I removed the calculate_async pp methods since they don't benefit from asynchronocity and if people need them async they can just wrap them in an async { ... }.await.

Async map parsing is super worth it though so that was a great addition. Also added an async_tokio feature so there's an option between async_std and tokio runtimes.

I'll let it run in some application for a few days to check if everything's working fine and then publish it as v0.2.0. 😃

Pure-Peace commented 3 years ago

❤️Nice!