MaxOhn / rosu-v2

A rust wrapper for the osu!api v2
MIT License
24 stars 9 forks source link

refactor!: remove rkyv feature #27

Closed MaxOhn closed 3 months ago

MaxOhn commented 3 months ago

This removes the rkyv feature and all the trait implementations that came with it.

The deserialization world contains various frameworks, each coming with their own strengths and weaknesses. It can be argued that it is too opinionated to support one over the other for a library.

Additionally, adding the code bloat of implementing traits for all types and their entire contained data is pretty much always overkill. Chances are users would only need support for very few types. And even when handling those types, serialization can often times be significantly improved by ignoring all pieces of irrelevant data.

For people that depended on the rkyv feature, I recommend to look into the rkyv::with::{ArchiveWith, SerializeWith, DeserializeWith} traits which essentially allow trait implementations of rkyv::{Archive, Serialize, Deserialize} on remote types. The rkyv-with even provides a way to derive those *With traits.