MaxServ / t3ext-fal_s3

S3 driver for FAL
GNU General Public License v2.0
13 stars 10 forks source link

[TASK] Fix mkdir not working reliable with S3 ACL calculation #61

Closed djcprinse closed 2 years ago

djcprinse commented 2 years ago

Fix mkdir not working with octdec value, let S3 determine permissions (ACL) inside the S3 StreamWrapper for the mkdir method.

Before, in versions lower than 1.10, the mkdir method was passing null to the mkdir method by accident (TYPO3 core changed the configuration path) and during that time, the Amazon S3 StreamWrapper was determing the permissions (and corresponding ACL) by itself. In version 1.10 and higher, the path to the TYPO3 configuration value has been fixed and wrapped the value in octdec which made the StreamWrapper incorrectly determine the correct permissions and correcsponding ACL.

With this change, the mkdir method will receive 0. This prevents strict type issues, because mkdir expects an integer as permissions argument. null and 0 will both let the StreamWrapper determine the correct ACL.