MaxServ / t3ext-fal_s3

S3 driver for FAL
GNU General Public License v2.0
13 stars 10 forks source link

Add suggestion for causal/extractor for extended metadata extraction #62

Closed djcprinse closed 2 years ago

djcprinse commented 2 years ago

With this adjustment, an optional dependency has been added for the causal/extractor extension to enrich the metadata that is being added to the TYPO3 metadata tables.

This way, additional data other than image dimensions and the default metadata can be extracted too while uploading or replacing files in the file admin.

The extractor Extraction classes have been XClasses because the could not be extended by using the Extbase object container, and the possible drivers can not be configured manually from within the extensions configuration.

Besides the adjustment for the XClasses Extraction services, the already implemented extractor has been renamed and moved to the Service/Extraction namespace and has been renamed to ImageDimensionsExtractor.

Also a minor bug has been fixed in which the getFileForLocalProcessing returned an incorrect value for a requested file. Instead of the temporary file, it was refering to a /tmp/phpXYZ file which was causing issues with metadata extraction. With this adjustment, we force to copy and use the real file for file extraction.

We might have to discuss what version we will tag this update to. Is it another feature release, or should we make this a breaking change if someone extends the Extractor class? And besides that, we might have to look if we still support TYPO3 v6 and up, or that we should change this dependency too and make this a major release.