search

MaxServ / t3ext-fal_s3

S3 driver for FAL
GNU General Public License v2.0
13 stars 10 forks source link

[BUGFIX] Partly reverted 1.13.1, since it caused performance issues. … #66

Closed DerFrenk closed 2 years ago

DerFrenk commented 2 years ago

Small regression fix for https://github.com/MaxServ/t3ext-fal_s3/pull/64:

With this changed behaviour, the ResourceStorage now can correctly mark a file as missing because the php is_file() method returned true if the $fileIdentifier was formatted correctly as a file identifier, and it was not checking if the file would exist on the storage.

This wasn't right. The AWS StreamWrapper overrides the is_file call and executes a headObject call. The result of this call is cached. Our custom headObject implementation didn't use any cache and caused performance issues.