search

MaxServ / t3ext-fal_s3

S3 driver for FAL
GNU General Public License v2.0
13 stars 10 forks source link

[BUGFIX] afterFileProcessing event exits early if the processed file is the same as the original file. #80

Closed mkarulin closed 2 months ago

mkarulin commented 6 months ago

If you store files on Amazon S3 but process them through fileadmin, you may run into an issue with some file types (like MP4), where TYPO3 backend no longer loads records that reference those files, because the processed file can't be found.

$event->getProcessedFile->exists() WILL return true when "userOriginalFile()" is true and that exists. I think this is true for all S3 files that don't get processed. Can someone verify?

If processed folder is not on the same storage as the origiginal file, then the followup getStorage()->getFileInfoByIdentifier() will not find the file and will return an error.

DerFrenk commented 2 months ago

I couldn't merge it, since it contains : mixed while we still support PHP 7.x. I applied the same change in a new PR and released it as https://github.com/MaxServ/t3ext-fal_s3/releases/tag/2.1.2 together with your other PR.

Thanks!