search

MaxServ / t3ext-fal_s3

S3 driver for FAL
GNU General Public License v2.0
13 stars 10 forks source link

[BUGFIX] Prevent undefined array key access #81

Closed fsuter closed 2 months ago

fsuter commented 3 months ago

Class FlushCacheActionEvent tries to take care of undefined array key access, but due to operator precedence the coalesce operator does not prevent it. Adding brackets takes care of the issue.

fsuter commented 3 months ago

I have added another change related to undefined array keys, when the driver tries to fetch the global TYPO3 request object. The code clearly expects a situation where the request is null because a test exists a few lines below. However access to TYPO3_REQUEST inside the $GLOBALS variable must still be hardened with a coalesce operator.

BTW this one is really a problem, because it is called so often, it is absolutely flooding my logs.