MaxTyutyunnikov / gphotoframe

Automatically exported from code.google.com/p/gphotoframe
Other
0 stars 0 forks source link

Support inotify (open image might be more verbose) #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. start gphotoframe
2. delete the image it is displaying from within the file manager
3. click 'open' to open the image file from gphotoframe

What is the expected output? What do you see instead?
nothing happens, I think an error message would be appropriate, telling me
the file doesn't exist.

What version of the product are you using? On what operating system?
svn version of gphotoframe and ubuntu 8.04

Please provide any additional information below.

Original issue reported on code.google.com by K.J.Nies...@gmail.com on 4 Jun 2009 at 8:23

GoogleCodeExporter commented 9 years ago
I would like to keep the behavior of gphotoframe simple.

gphotoframe should not display the delete image, 
which is checking with inotify in real time.

Original comment by yendo0206 on 5 Jun 2009 at 6:16

GoogleCodeExporter commented 9 years ago
I think I meant something else.
If it is ok I will try to prepare a patch to show you what I mean.
Then, off course, you can decide whether you want it or not.

Original comment by K.J.Nies...@gmail.com on 6 Jun 2009 at 8:54

GoogleCodeExporter commented 9 years ago
This is what I was trying to make clear. The patch is not perfect as my python 
coding
skills are not so good. I don't know how to close the message dialog by 
clicking on
the 'OK' button.
It is for you to decide if you want this in your program. So use this patch if 
you
like to.

Original comment by K.J.Nies...@gmail.com on 6 Jun 2009 at 9:19

Attachments:

GoogleCodeExporter commented 9 years ago
I think that it is necessary to prevent users from being able to do the 
operation
causing errors.
The display of the error dialog is the final means. 

Original comment by yendo0206 on 8 Jun 2009 at 9:13

GoogleCodeExporter commented 9 years ago
If the local image file does not exist, the sensitivity of the 'open' menu item 
is
set 'inactive'.  Implemented in r142.

But, It is insufficient without inotify support.

Original comment by yendo0206 on 9 Jun 2009 at 4:26

GoogleCodeExporter commented 9 years ago
Added inotify support in r184.

Original comment by yendo0206 on 30 Jun 2009 at 4:33

GoogleCodeExporter commented 9 years ago
Fixed in r187.

Original comment by yendo0206 on 1 Jul 2009 at 7:10