menu border has arrow symbol (bottom right)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. menu.lst with just 

title root
root

look at border - one of the | characters at bottom right of menu border is a 
down-arrow symbol

see 
http://www.rmprepusb.com/_/rsrc/1358346802346/tutorials/grub4dos/g4dos_menu_box.
jpg

2.
3.

What is the expected output? What do you see instead?

should be smooth border

What version of the product are you using? On what operating system?
OK in 2011-06-07, 2011-08-08, 2011-11-03, 2011-11-22, 2011-11-29, 2011-12-06
NOT OK in 2011-12-10 and later versions

Please provide any additional information below.

Original issue reported on code.google.com by Steve6375 on 17 Feb 2013 at 4:28

[GoogleCodeExporter]

It should be caused by r246, more precisely, this change:

369     369         
370     370         /* Print entries in the menu box. */
371     371         static void
372         -   print_entries (int first, int entryno, char *menu_entries, char 
*config_entries)
    372     +   print_entries (int first, int entryno, char *menu_entries)
373     373         {
374     374         int i;
375         -   int main_menu = (menu_entries == (char *)titles);
376         -   
    375     +   //int main_menu = (menu_entries == (char *)titles);
377     376         if (current_term->setcolorstate)
378     377         current_term->setcolorstate (COLOR_STATE_NORMAL);
379     378         gotoxy (MENU_BOX_E, MENU_BOX_Y);
380     379         
381     380         #ifdef SUPPORT_GRAPHICS
382     381         if (!graphics_inited || graphics_mode < 0xff)
383     382         #endif
    383     +   {
384     384         if (first)
385     385         grub_putchar (DISP_UP, 255);
386     386         else
387     387         grub_putchar (DISP_VERT, 255);
388         -   
389         -   if (main_menu || *menu_entries)
390         -   menu_entries = get_entry (menu_entries, first);
    388     +   }
    389     +   //if (main_menu || *menu_entries)
    390     +   // menu_entries = get_entry (menu_entries, first);
391     391         
392     392         for (i = 0; i < MENU_BOX_H/*size*/; i++)
393     393         {
394         -   print_entry (MENU_BOX_Y + i, entryno == i, menu_entries, 
config_entries);
    394     +   print_entry (MENU_BOX_Y + i, entryno == i, first + i, menu_entries);
395     395         
396         -   if (main_menu)
397         -   {
398         -   if (menu_entries)
399         -   {
400         -   if ((++first) < 256)
401         -   menu_entries = titles[first];
402         -   else
403         -   menu_entries = 0;
404         -   }
405         -   continue;
406         -   }
407         -   if (*menu_entries)
408         -   while (*(menu_entries++));
    396     +   // if (main_menu)
    397     +   // {
    398     +   //if (menu_entries)
    399     +   //{
    400     +   // if ((++first) < 256)
    401     +   //  menu_entries = titles[first];
    402     +   // else
    403     +   //  menu_entries = 0;
    404     +   //}
    405     +   //continue;
    406     +   // }
    407     +   // if (*menu_entries)
    408     +   //while (*(menu_entries++));
409     409         }
410     410         
    411     +   #ifdef SUPPORT_GRAPHICS
    412     +   if (!graphics_inited || graphics_mode < 0xff)
    413     +   #endif
    414     +   {
411     415         gotoxy (MENU_BOX_E, MENU_BOX_Y - 1 + MENU_BOX_H/*size*/);
412     416         
413     417         if (current_term->setcolorstate)
414     418         current_term->setcolorstate (COLOR_STATE_NORMAL);
415         -   #ifdef SUPPORT_GRAPHICS
416         -   if (!graphics_inited || graphics_mode < 0xff)
417         -   #endif
418     419         if (menu_entries && *menu_entries)
419     420         grub_putchar (DISP_DOWN, 255);
420     421         else
421     422         grub_putchar (DISP_VERT, 255);
422         -   
423     423         if (current_term->setcolorstate)
424     424         current_term->setcolorstate (COLOR_STATE_STANDARD);
425         -   
    425     +   }
426     426         gotoxy (MENU_BOX_E, MENU_BOX_Y + entryno); /* XXX: Why? */
427     427         }
428     428         

Hopefully chenall would handle it.

Original comment by tinyb...@gmail.com on 1 Mar 2013 at 3:22

• Changed state: Accepted

[GoogleCodeExporter]

Solved, thank you.

Original comment by chenall.cn on 2 Mar 2013 at 3:55

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by chenall.cn on 3 Mar 2013 at 12:27

• Changed state: Done