MaxVerevkin / i3bar-river

A port of i3bar for wlroots-based compositors
GNU General Public License v3.0
39 stars 5 forks source link

Tag background colors stack up #17

Closed triallax closed 1 year ago

triallax commented 1 year ago

This is how my i3bar-river config looks with a transparent tag_bg and tag_focused_bg: image

So the background colors of the tags stack up on the background color of the bar as a whole, which is contrary to swaybar's behavior but also something I find generally confusing and unintuitive. Instead, I think the background color of the tags should only be determined by tag_bg (or the appropriate config variable).

MaxVerevkin commented 1 year ago

Yes, tags (and any other graphics drawn) blend with the background. Can you share a screenshot of the expected behavior? To me, transparent tag_bg mean that tags should not have a background, which is the case in your screenshot.

triallax commented 1 year ago

To me, transparent tag_bg mean that tags should not have a background, which is the case in your screenshot.

Sorry, I guess my screenshot isn't clear because of the transparency, but their background is in fact the same as the rest of the bar. Here's an image that makes that clearer:

image

tag_bg and tag_focused_bg are also transparent here, so the tag takes on the color of the bar, but what I would expect is for it to take on the color of the background image instead.

Can you share a screenshot of the expected behavior?

Here's swaybar with the workspace colors set to transparent:

image

Does that make what I mean clearer?

MaxVerevkin commented 1 year ago

Does that make what I mean clearer?

Yes. Does swaybar render (blend) everything like this, including status line, or just the workspaces?

triallax commented 1 year ago

swaybar uses the normal bar background for the rest of the bar (including the status line). The only other thing in the bar with a separately configurable background is binding_mode, which is also rendered like this.

MaxVerevkin commented 1 year ago

swaybar uses the normal bar background for the rest of the bar (including the status line).

Just to clarify, I mean if you set blocks background to transparent directly in JSON, do you see your bar's background or your wallpaper (like you do with workspaces)?

something I find generally confusing and unintuitive

Interesting, for me its the opposite :) I guess I can add blend option to configure this. blend = true would be the current behavior and blend = false is what swaybar does.

triallax commented 1 year ago

Just to clarify, I mean if you set blocks background to transparent directly in JSON, do you see your bar's background or your wallpaper (like you do with workspaces)?

Right, I forgot that I can set the block's background in the JSON output. Anyway, again, I see my wallpaper:

image

Interesting, for me its the opposite :) I guess I can add blend option to configure this. blend = true would be the current behavior and blend = false is what swaybar does.

Sure, that's an acceptable solution for me. We can bikeshed on the default value later. :P

MaxVerevkin commented 1 year ago

Here you go e07d987

triallax commented 1 year ago

Thanks again!