MaxVerevkin / i3bar-river

A port of i3bar for wlroots-based compositors
GNU General Public License v3.0
39 stars 5 forks source link

Allow scrolling between workspaces #35

Closed vpzomtrrfrt closed 2 months ago

vpzomtrrfrt commented 2 months ago

Another feature I'm missing from sway, it would be nice to be able to switch between workspaces with the scroll wheel

MaxVerevkin commented 2 months ago

Yeah, seems reasonable. Just a few details:

  1. Which direction corresponds to 'go left' and which to 'go right'?
  2. River has tags instead of workspaces, and several tags can be active at the same time. What to do in these cases?
vpzomtrrfrt commented 2 months ago
  1. looks like scroll down for right, up for left
  2. I can't really speak to what River users expect, as I've never used it. Maybe disable in that case or use only the leftmost tag?
tunalad commented 2 months ago
2. River has tags instead of workspaces, and several tags can be active at the same time. What to do in these cases?

you could shift them all together too. On dwm I use this patch, which deals with that problem (by just shifting everything)

MaxVerevkin commented 2 months ago

looks like scroll down for right, up for left

Alright.

you could shift them all together too

That's the easiest option a guess, and a sensible one too. Not sure about the wrapping around tag 9, river has 32 tags after all. I will probably not implement wrapping at all.

tunalad commented 2 months ago

Not sure about the wrapping around tag 9, river has 32 tags after all.

maybe limit it to the max_tags, or a different config option to limit the number to. But I think this would just be useful for the visible tags on the bar, and not the ones you don't see

MaxVerevkin commented 2 months ago

Implemented in dbcaa19. On river it shifts the tags until only one is focused (either the 1st or 32nd).