MaxWasUnavailable / LobbyCompatibility

Towards a future with fewer lobby incompatibility errors.
GNU Lesser General Public License v3.0
5 stars 3 forks source link

Revert "Create a new Assembly Attribute for an easy Soft Dependency" #64

Closed Xilophor closed 6 months ago

Xilophor commented 6 months ago

Reverts MaxWasUnavailable/LobbyCompatibility#56

Due to NGO using Assembly.GetCustomAttributes(Type, bool) and a potential flaw(?) in that method, it loads all attributes of the assembly, including the SoftLobbyCompatibility attribute, which may not have an assembly to reference (soft dependency).

This causes an error to occur when running that method, preventing NGO from working. The only available solution without potential side-effects is to just go back to using the Register method previously/currently provided.