blueCat11 commented 5 years ago

12

Beautifying (and showing form only when keys selected for analysis) still necessary, but I opened #52 for that.

Maxikilliane commented 5 years ago

@blueCat11 I try to resolve the merge conflicts for you :)

blueCat11 commented 5 years ago

Thanks! If you run into problems, because you don't know what something is supposed to be, feel free to wait until Monday, then we can do it together.

Maxikilliane commented 5 years ago

@blueCat11 not so clever of me, but I integrated my changes into the "merge master into this branch" commit, so reviewing my changes is quite impossible. Sorry, I didn't do it on purpose. What I basically did was:

I added a "disabled" logic to the analyse button, because when the user only clicks the key checkbox, there is no need to click the analyse button, because the analysis part is already done. So the interface looks like this:
When the user clicks the chord AND the key check box, the user gets to choose which key he wants to use. There are not just checkboxes, but also a different text. The Analyze Button is now enabled. It looks like this:
When clicking one of the other checkboxes the Analyse Button is also enabled (I don't know yet, whether this will change in the future, but thats like I implemented it for now.)

blueCat11 commented 5 years ago

I like your UI, and the idea to disable if there is nothing selected! That's definitely good. Since you say I can't test, I'm just going to trust you that it will work!

Maxikilliane / DH_MusicAnalysis

12 analyze key #53

12