search

Maxikilliane / DH_MusicAnalysis

0 stars 0 forks source link

13 download graphs #84

Closed blueCat11 closed 5 years ago

blueCat11 commented 5 years ago

13

Charts are now downloadable by button click. For those charts where the legend does not get downloaded, there is an additional button to enable downloading of the legend.

RiaRentnueg commented 5 years ago

I can download all charts without any problems. It would be better if it was possible to download all graphs with their legends, but I guess you tried to implement that and it didn't work.

When I download the graphs the naming is as following: ct-chart-name.png ct-chart-pitch-name.png ct-chart-duration-fullname-notes-count.png

I'm not shure if that is wanted or if name or fullname is only a placeholder.

When I download the ambitus graphs they are named: ct-chart-ambitus-range-0.png and ct-chart-ambitus-range-1.png I tested it with the groups bach and beethoven, so I guess 0 should stand for bach and 1 for beethoven. Is it possible to change the naming?

blueCat11 commented 5 years ago

Thanks for the suggestions. You were right, I couldn't get the legends and charts together, so I thought it's better than nothing like that. Fullname is fine, but I added "chord" to the first, so it's clearer what they are about. I also changed the ambitus-download to have the groups in their name.