search

Maxikilliane / DH_MusicAnalysis

0 stars 0 forks source link

76 axis titles #90

Closed blueCat11 closed 5 years ago

blueCat11 commented 5 years ago

76

There are now axis titles/labels/legends on thoses charts where I deemed it necessary. I did not add axis titles for all the charts, because I did not think adding "number of x" to all the y-axes to be a valuable change. If you disagree, feel free to tell me in a review, then I can incorporate that.

Maxikilliane commented 5 years ago

Both titles (on the x and y axis need more padding, especially the one on the y-axis) need more padding and I think they should be the same size (the label on the y axis is way too small, you can barely read it) and I think a greyish color (the same used in the diagram itself for the numbers) would look way better.

Bildschirmfoto 2019-04-07 um 19 52 00
Maxikilliane commented 5 years ago

Here the padding problem is especially visible:

Bildschirmfoto 2019-04-07 um 19 55 36
blueCat11 commented 5 years ago

That's a problem, because I can't give infinitely more padding with this chartist-plugin. If it gets too much, the axistitle simply gets moved out of the svg and becomes completely invisible. The same problem arises with the sound-to-silence-ration y-axis, the end of the axis-title string and the beginning of it simply get cut off, because it's too long, if I use a larger font-size. @Maxikilliane do you have an idea for a shorter phrasing? Or maybe we could swap the graph around so the x-axis becomes the y-axis...? I can change the color though.

blueCat11 commented 5 years ago

I've tried to incorporate your requests @Maxikilliane, would you re-review?