search

MaximBalaganskiy / AureliaDotnetTemplate

Aurelia .Net Template
43 stars 14 forks source link

Shouldn't the router be of type AppRouter instead of Router ? #10

Closed gcastre closed 5 years ago

gcastre commented 5 years ago

Because it is the main router and so you cannot use some function like Deactivate()

https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/blob/master/ClientApp/app/components/app/app.ts#L5

Definition ref:

https://github.com/aurelia/router/blob/master/dist/aurelia-router.d.ts#L875-L906

MaximBalaganskiy commented 5 years ago

The signature is copied from https://aurelia.io/docs/routing/configuration#basic-configuration Never had any problems with it...

On Tue, Jun 11, 2019, 7:05 PM Grégoire Castre notifications@github.com wrote:

Because it is the main router and so you cannot use some function like Deactivate()

https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/blob/master/ClientApp/app/components/app/app.ts#L5

Definition ref:

https://github.com/aurelia/router/blob/master/dist/aurelia-router.d.ts#L875-L906

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/issues/10?email_source=notifications&email_token=AA4KNPAZ6KNCHP4PETKOE23PZ5TFTA5CNFSM4HW4DYSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYYFDUQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4KNPAHVAVEGLJCFVHUFZDPZ5TFTANCNFSM4HW4DYSA .