Closed shahabganji closed 5 years ago
I saw someone mentioned aurelia-dialog issues recently on gitter, I would have a look at that repository first
On Sun., 14 Oct. 2018, 2:07 pm Saeed Ganji, notifications@github.com wrote:
Hi @MaximBalaganskiy https://github.com/MaximBalaganskiy ,
I forked https://github.com/shahabganji/AureliaDotnetTemplate your repository and just added the aurelia-toolbelt package to it, however, one way or the other it has an error at bootstrapping the Aurelia app.
[image: image] https://user-images.githubusercontent.com/4405518/46913577-d7f7f700-cf9c-11e8-88ee-9aca0788a5d5.png
I have just added this line to the boot.ts file
aurelia.use.standardConfiguration() .plugin(PLATFORM.moduleName("aurelia-toolbelt"));
Can you take a look at this problem, or give me some hints?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/ADimvLMcpU1Kkc001ga5-gkb1sCPOWtWks5ukuLLgaJpZM4Xa_qK .
@MaximBalaganskiy
I speculate that it is related to aurelia-dialog
too, what I see from the logs of the issue, however, to make sure I'll check with older versions of aurelia-toolbelt
in which we do not have aurelia-dialog
.
One question out of my curiosity, how this repository differs from what aurelia-cli
creates? does it have benefits over cli version?
Have a great day :+1:
It was created as a continuation of the retired official dotnet template. Last time I looked, cli handles bundling slightly differently - it requires a manual list of vendor packages plus there is no bs4 in the cli's template
On Sun., 14 Oct. 2018, 2:54 pm Saeed Ganji, notifications@github.com wrote:
@MaximBalaganskiy https://github.com/MaximBalaganskiy
I speculate that it is related to aurelia-dialog too, what I see from the logs of the issue, however, to make sure I'll check with older versions of aurelia-toolbelt in which we do not have aurelia-dialog.
One question out of my curiosity, how this repository differs from what aurelia-cli creates? does it have benefits over cli version?
Have a great day 👍
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/issues/4#issuecomment-429604631, or mute the thread https://github.com/notifications/unsubscribe-auth/ADimvC5O65fsOw55XQoW7EbO86s3NsvIks5uku21gaJpZM4Xa_qK .
Check out my fork https://github.com/gregoryagu/AureliaDotnetTemplate It's been updated a bit from the original.
Thanks, @gregoryagu,
I checked your fork and it has the same problem with aurelia-dialog
Is this still relevant?
I would prefer this template, so the answer is yes, have you changed anything?
Nope. I thought it was mostly aurelia-dialog issue. In the materialise demo project I had to turn off module concatenation in webpack which was not compatible with the latest aurelia-dialog
On Sun., 28 Oct. 2018, 5:15 pm Saeed Ganji, notifications@github.com wrote:
I would prefer this template, so the answer is yes, have you changed anything?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/issues/4#issuecomment-433679618, or mute the thread https://github.com/notifications/unsubscribe-auth/ADimvAvvznn4nZo1HRLqWnoZqWPyO_-oks5upUtngaJpZM4Xa_qK .
So, the workaround is to turn off the module concatenation plugin? I didn't see that you have used that in this template, right?
Well, the template does not need this as it does not use the dialog plugin. Mind you, it's just a guess based on the other project :)
On Sun, 28 Oct 2018 at 22:02, Saeed Ganji notifications@github.com wrote:
So, the workaround is to turn off the module concatenation plugin? I didn't see that you have used that in this template, right?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/issues/4#issuecomment-433695009, or mute the thread https://github.com/notifications/unsubscribe-auth/ADimvC0HLIA2VYGlcnpNMKlHIhn5e4Dlks5upY7QgaJpZM4Xa_qK .
Yes, however, aurelia-dialog plugin is one that will be of use in most of Aurelia based SPAs.
On Oct 28, 2018, at 14:53, Max notifications@github.com wrote:
Well, the template does not need this as it does not use the dialog plugin. Mind you, it's just a guess based on the other project :)
On Sun, 28 Oct 2018 at 22:02, Saeed Ganji notifications@github.com wrote:
So, the workaround is to turn off the module concatenation plugin? I didn't see that you have used that in this template, right?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/issues/4#issuecomment-433695009, or mute the thread https://github.com/notifications/unsubscribe-auth/ADimvC0HLIA2VYGlcnpNMKlHIhn5e4Dlks5upY7QgaJpZM4Xa_qK .
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
Can you please check that the fix is working for your package?
On Sun., 28 Oct. 2018, 10:31 pm Saeed Ganji, notifications@github.com wrote:
Yes, however, aurelia-dialog plugin is one that will be of use in most of Aurelia based SPAs.
On Oct 28, 2018, at 14:53, Max notifications@github.com wrote:
Well, the template does not need this as it does not use the dialog plugin. Mind you, it's just a guess based on the other project :)
On Sun, 28 Oct 2018 at 22:02, Saeed Ganji notifications@github.com wrote:
So, the workaround is to turn off the module concatenation plugin? I didn't see that you have used that in this template, right?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/issues/4#issuecomment-433695009 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ADimvC0HLIA2VYGlcnpNMKlHIhn5e4Dlks5upY7QgaJpZM4Xa_qK
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MaximBalaganskiy/AureliaDotnetTemplate/issues/4#issuecomment-433696831, or mute the thread https://github.com/notifications/unsubscribe-auth/ADimvIV5WLPqBaMNoMQU9rCqvG0v1D2Uks5upZWAgaJpZM4Xa_qK .
Can you please check that the fix is working for your package?
The fix is to turn off the module concatenation in webpack
? I'll check.
@shahabganji Any luck?
I’ll check it on the weekend.
On Oct 30, 2018, at 02:08, Max notifications@github.com wrote:
@shahabganji Any luck?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@MaximBalaganskiy
I checked this on my fork and changed some stuff, however, when I cloned your repository again and checked aurelia-dialog and aurelia-toolbelt, both look to work properly. I am not sure why, but maybe sth related to this commit. Anyway I added aurelia-toolbelt on my forked repository. If you'd like I can make a pull request, otherwise there might not be any big differences. BTW, I am not sure but I remember that one said MiniCssExtraxtPlugin might be better than ExtractTextWebpackPlugin. What's your opinion of replacing these two guys?
And, since I didn't see the problem any more I'll close the issue.
Thanks
According to https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/749#issuecomment-374549467 MiniCss should be used from now on. Good point
Hi @MaximBalaganskiy ,
I forked your repository and just added the
aurelia-toolbelt
package to it, however, one way or the other it has an error at bootstrapping the Aurelia app.I have just added this line to the
boot.ts
fileCan you take a look at this problem, or give me some hints?