MaximilianKoestler / hcloud-openapi

This is the unofficial OpenAPI description of the Hetzner Cloud API. It allows automatic code generation for the hcloud API.
MIT License
29 stars 5 forks source link

Missing os_flavor "rocky" causing breakage for hcloud-rust #15

Closed MathiasPius closed 2 years ago

MathiasPius commented 2 years ago

It looks like with the release of Rocky Linux as a supported operating system, "rocky" is missing as an enum variant for the os_flavor types, even in the official OpenAPI spec.

https://github.com/MaximilianKoestler/hcloud-openapi/blob/6b7851bbd5d29004517943b80cd3ff0ed0b7301d/openapi/hcloud.json#L2884-L2892

I've reported the issue to Hetzner, but I figured I'd report it here too since it impacts downstream projects such as hcloud-rust by breaking image listing (serde decode errors due to unknown variant rocky).

MaximilianKoestler commented 2 years ago

Thank you for the report. This issue should be fixed with spec release v0.7.0, it would indeed have been nice if Hetzner mentioned this somewhere in the docs.

I will inform the downstream maintainer for hcloud-rust of this change.

HenningHolmDE commented 2 years ago

Thanks for letting us know, @MathiasPius.

I just released version 0.10.0 for hcloud-rust that contains the fixed enumeration and should fix any deserialization issues with Rocky Linux servers.