search

MaximumADHD / Character-Realism

A flexible character enhancement system for Roblox.
Mozilla Public License 2.0
103 stars 25 forks source link

[RE-PR] Add sprinting into Character Realism. #16

Closed Hedreon closed 2 years ago

Hedreon commented 2 years ago

I had to re-do the pull request since my old pull request had a conflict I cannot fix so I had to make a new one.

Create new script.

Kassiee commented 2 years ago

maybe don't set the script's parent to the character, it removes the script when you die, or find a way for that not to happen

Hedreon commented 2 years ago

maybe don't set the script's parent to the character, it removes the script when you die, or find a way for that not to happen

Hm. Interesting... Yeah ill change it to starter character scripts. I hope thatll fix it

MaximumADHD commented 2 years ago

I'm not sure if I'm really interested in integrating sprinting into realism directly since the focus is more on the joint rotation and walking sounds.

Hedreon commented 2 years ago

maybe don't set the script's parent to the character, it removes the script when you die, or find a way for that not to happen

Line removed.

Kassiee commented 2 years ago

I see you revamped the script a lot, and I've tried it... I don't know if I'm doing something wrong since I just pasted the entire script and it doesn't work

Kassiee commented 2 years ago

(nevermind I realised it was a damn module)

Hedreon commented 2 years ago

seems like freecam is hella bugged when using this module... I'll try to fix it as best as I can.

UPDATE 1: Seems like this issue is also happening with the old sprint local script. Becoming a bit more likely that this is roblox's end. Just a tiny bit.

UPDATE 2: For now, change the keycodes to something like R or RightShift. If you want to continue using leftshift as the keycode for PC, you would have to modify the freecams code to change the keycode for activating it. I do not know how to fix this myself. This has to be roblox's end.

UPDATE 3: I figured it out. Using first person and activating freecam using the classic camera mode will definitely glitch out the camera a lot. This is DEFINITELY confirmed to be roblox's end. I actually also experienced different issues a bit similar to this while using first person.

UPDATE 4: After deep investigation, it is actually confirmed that the sprint module is causing this, not character realism, not the freecam script & not roblox. It is caused due to bad camera implementation.

Kassiee commented 2 years ago

Something that would be great to add into something like this, is altering the player's walkspeed based on walking direction. slower walkspeed when walking backwards, as an example

Hedreon commented 2 years ago

Something that would be great to add into something like this, is altering the player's walkspeed based on walking direction. slower walkspeed when walking backwards, as an example

Will add not

Update: After careful consideration, I have decided I will not do that as that is unrelated to sprinting. It's sprinting only but, I might add another module for walking that add the features you suggested & with that, I will add bobbing into FpsCamera or the Movement module but that only happens if I decide to add another module.

Update 2: Its been decided! The movement module, it's not gonna happen.

Hedreon commented 2 years ago

I give up fixing this thing, I'll just remove those FOV changes because it seems like I didn't actually fix it and I only realised this today. The sprint module, with the FOV feature is ONLY fully compatible with first person games, not third person games

Hedreon commented 2 years ago

Nevermind, it's broken af, did further tests.

Should've done an issue, as a feature request instead. Woulda' been much easier