search

MaximumADHD / Roblox-Studio-Mod-Manager

An open-source custom bootstrapper for Roblox Studio that allows you to override files in Roblox Studio's directory, opt into development branches of Roblox, and experiment with Fast Flags.
MIT License
282 stars 52 forks source link

Studio updates force close all active Studio processes #211

Open HooferDevelops opened 4 months ago

HooferDevelops commented 4 months ago

When launching the Mod Manager, in the event there is an update for Roblox Studio, it will forcefully close all active studio processes. It does this prior to asking if I would like to close studio.

This is really frustrating, as there are cases where I mistakenly have clicked on mod manager, for it to open and forcefully close all of my studio sessions before I have time to react.

The intended behavior should be that it would only kill the processes after I confirm my action.

HooferDevelops commented 4 months ago

This issue happens here: https://github.com/MaximumADHD/Roblox-Studio-Mod-Manager/blob/3d289f047b66bf40db58d6e7f8a959ec6984190b/ProjectSrc/Bootstrapper/StudioBootstrapper.cs#L673-L752

You can see that it attempts to close all the processes prior to the prompt.

MaximumADHD commented 4 months ago

Sure, I'll tweak this.

HooferDevelops commented 4 months ago

Another bug I found is that the message box prompts below the Mod Manager, I've found this can be fixed by adding MessageBoxDefaultButton.Button1, MessageBoxOptions.DefaultDesktopOnly to the MessageBox.Show prompt.

I fixed these issues myself on a separate branch, I can PR if wanted.

https://github.com/user-attachments/assets/2bf6c064-3825-430e-838a-ca07670d649a