search

Maximus5 / ConEmu

Customizable Windows terminal with tabs, splits, quake-style, hotkeys and more
https://conemu.github.io/
BSD 3-Clause "New" or "Revised" License
8.55k stars 571 forks source link

Redundant ConEmu.xml update #10

Open ralish opened 10 years ago

ralish commented 10 years ago

When ConEmu is configured in portable mode and is opened and closed it will update the ConEmu.xml file with the current "modified" time. This can be quite frustrating when no other settings in the configuration have changed and you keep your ConEmu.xml file in a VCS such as Git as it will result in the ConEmu.xml file always being marked as modified.

An example from a Git diff (with no other changed lines):

-               <key name=".Vanilla" modified="2014-05-02 20:48:18" build="140422">
+               <key name=".Vanilla" modified="2014-05-02 20:52:17" build="140422">

I think it would be preferable that the ConEmu.xml modified timestamp is only updated if the ConEmu.xml file has actually been modified instead of always updating the timestamp every exit even if there are no actual changes. Thoughts?

Maximus5 commented 10 years ago

That may be if you choose to "Auto save window size/position" or "... opened tabs" on exit.

ralish commented 10 years ago

I can confirm from testing it does appear to be caused by the "Auto save window size and position on exit" option. It'd still be really helpful though if ConEmu could more "intelligently" update its XML file only when necessary to reduce or even eliminate unnecessary updates (especially useful when the file is being stored in a VCS system and thus keeps being marked as modified).

Maximus5 commented 10 years ago

http://code.google.com/p/conemu-maximus5/issues/detail?id=1643

schlamar commented 10 years ago

If you really need the timestamp stored for individual config sections (why exactly if you don't mind?), you might want to consider storing them in a separate file instead, so it can be gitignored.

Maximus5 commented 10 years ago

Timestamp is (and must) be used to monitoring if the key was changed. The issue is not about timestamps, but about spare updating if the Keys even they was not changed actually. And this will be "fixed" of course.

schlamar commented 10 years ago

I guess this would still solve @ralish's problem but I opened a new issue for this: https://github.com/Maximus5/ConEmu/issues/15

Maximus5 commented 10 years ago

140905

r3c commented 8 years ago

It seems build 160904 still updates modified timestamp for "Tasks" and all "TaskN" keys, along with "Apps" and "Colors" ones whenever some unrelated setting is changed. Is this intended?

Anutrix commented 5 years ago

Any updates?