Maximus5 / ConEmu

Customizable Windows terminal with tabs, splits, quake-style, hotkeys and more
https://conemu.github.io/
BSD 3-Clause "New" or "Revised" License
8.61k stars 574 forks source link

Installer update kills ConEmu session #156

Open pyhedgehog opened 9 years ago

pyhedgehog commented 9 years ago

Reproduce

Once installer starts it forcibly closes conemu with all tabs including chocolatey console. You can't see installer results (especially if you've run update for several packages).

Wanted results

Variant 1

pyhedgehog commented 9 years ago

For me personally adding option "Detach consoles on closing" would be enough.

Maximus5 commented 9 years ago

It is practically impossible to update ConEmu binaries within ConEmu session. Even detaching consoles will not behave properly because of http://conemu.github.io/en/ConEmuHk.html

ConEmu has its own auto update procedure which consider all issues.

But with chocolatey... Hmm. I'm not sure if it's possible at the moment. Update must be started outside of ConEmu window somehow. http://conemu.github.io/en/DefaultTerminal.html http://conemu.github.io/en/NewConsole.html

pyhedgehog commented 9 years ago

I've not found in you url why "detach on conemu window close" is impossible (however every tab in conemu has detach option right now), but I trust your experience in this topic. What about using pending moves in installer?

Maximus5 commented 9 years ago

Detach is possible but several dll-s will remain loaded in started processes.

pyhedgehog commented 9 years ago

Why stopping injected threads and FreeLibrary can't help? Once again - what about using pending moves in installer?

Maximus5 commented 9 years ago

FreeLibrary may kill process in some cases.

Pending moves will work only on reboot. That is unwanted behavior I believe.

Anyway, the issue is complicated and requires some investigations...

pyhedgehog commented 9 years ago

Why you think that it's unwanted behavior? It's standard behavior for system-wide updates. Console window is definitely system object. Isn't it?

jeffjensen commented 7 years ago

I've used Chocolately and ConEmu for quite awhile and this problem recently happened to me because I recently made ConEmu the default term per https://conemu.github.io/en/DefaultTerminal.html

Is there a switch or something to launch an admin console using cmd -new_console:z ?

Maximus5 commented 7 years ago

Only the one session may survive after choco update. Regardless of that, you should restart the console manually after update. That is due to protocol changes between versions and other issues. Choco update script warns user about that.

jeffjensen commented 7 years ago

Yes, I would restart ConEmu / any console after the Choco update. However, that is not the issue I'm asking about because ConEmu crashes with the Choco update.

To prevent ConEmu crashing during update with Choco, I want to run Choco in an admin term that is not ConEmu. Since ConEmu is now the default term, how do I start the admin term?

Maximus5 commented 7 years ago

In my tests ConEmu didn't crash on update from choco tab, started in ConEmu of course.

jeffjensen commented 7 years ago

I have 5 ConEmu .dmp files from it; it kept seg faulting so I killed it after the 5th. Do you want the first one or any of them?

Maximus5 commented 7 years ago

First dump.

jeffjensen commented 7 years ago

Trap-170910-10612.zip