search

Maximus5 / ConEmu

Customizable Windows terminal with tabs, splits, quake-style, hotkeys and more
https://conemu.github.io/
BSD 3-Clause "New" or "Revised" License
8.55k stars 571 forks source link

Hyperlinks not underlined by default #2369

Open mrx23dot opened 2 years ago

mrx23dot commented 2 years ago

Versions

ConEmu build: Conemu 210718 x64 OS version: Windows 7+10 x64 Used shell version: cmder 1.3.18.1106 https://github.com/cmderdev/cmder

Problem description

In linux web links are automatically underlined indicating that they are clickable with CTRL.

Steps to reproduce

  1. type in console: echo http://www.google.com

Actual results

http://www.google.com is printed but not underlined link

Expected results

It should be underlined indicating that it's clickable while holding CTRL key under

Additional files

config https://github.com/cmderdev/cmder/blob/8d6ce3e4acf86c9418adf1114b0d261e71c5a511/vendor/ConEmu.xml.default

Original issue in hosting app https://github.com/cmderdev/cmder/issues/2599

Maximus5 commented 2 years ago

No. What you see is expected behavior. CPU is consumed for checking the "clickable" parts only when you hover the mouse with Ctrl pressed.

mrx23dot commented 2 years ago

Isn't the goal to emulate all aspects of unix consoles? If it slows things down there could be an option to disable it (but I don't think a regexp over 1000 line buffer would be slow on anything that can run win7/win10)

dodmi commented 2 years ago

I like the current behavior. So, it's consistent with other text, which will be linkified on Ctrl + Mouse over. I prefer all linkifyable parts not to be underlined automatically.

mrx23dot commented 2 years ago

The argument for it would be that it gives visual anchors, e.g. in a huge log file it helps to see structure, since line wrapping is always on in ConEmu, eg these 2 line:

no_structure