Maximus5 / ConEmu

Customizable Windows terminal with tabs, splits, quake-style, hotkeys and more
https://conemu.github.io/
BSD 3-Clause "New" or "Revised" License
8.5k stars 570 forks source link

ConEmu\ExtendedConsole[64].dll loading is not handled in OnLoadLibraryExW hook #2507

Open alabuzhev opened 1 year ago

alabuzhev commented 1 year ago

Versions

ConEmu build: master x64 OS version: Windows 10 x64 Used shell version (Far Manager, git-bash, cmd, powershell, cygwin, whatever): Far

Problem description

Conemu comes with a dll to support true color in Far: ConEmu\ExtendedConsole[64].dll. To load it from a custom location Conemu hooks LoadLibraryW in Far, assuming that this function is used to load the dll. In 6076 (9c9494dd10) Far switched from LoadLibraryW to LoadLibraryExW. LoadLibraryExW hook in Conemu does not include this logic, so dll is no longer loaded and Conemu does not recieve FarColor arrays directly. I can revert this change in Far of course, but I prefer not to:

Steps to reproduce

  1. Get the latest Far
  2. Run from Conemu
  3. Check the loaded modules

Expected results

ConEmu\ExtendedConsole[64].dll should be loaded

Actual results

ConEmu\ExtendedConsole[64].dll is not loaded