search

Maximus5 / conemu-inside

An example, how to embed http://conemu.github.io/ into another graphical application
57 stars 46 forks source link

ConEmu Inside seems not to react on startup shell configuration #27

Open Therena opened 8 years ago

Therena commented 8 years ago

If I set a startup shell in the conemu config and use this config within conemu integration it isn't taken into account. Setting: 23-06-_2016_21-43-42 Open ConEmu using ConEmu inside 23-06-_2016_21-48-50 This was originally a request from the user xsxxxxx on the page of the Visual Studio extension: https://visualstudiogallery.msdn.microsoft.com/a0536370-40e4-4141-8f51-5f00d0434012

Therena commented 8 years ago

See also initial bug request from @PhilipDaniels: https://github.com/Therena/ConEmuIntegration/issues/6

To solve this bug I need the here requested functionality.

hypersw commented 8 years ago

ConEmu issues a command when it starts, as given in the startinfo, and then happens what's written in the label above — the startup task gets overridden with /cmd. You can specify {Bash::Git bash} as the startup command (the default is {cmd}), and this would open the task. Would it do to read the task name from the config and supply it as the ConsoleProcessCommandLine into the startinfo?

Alternatively, I could make startinfo let an empty string for the ConsoleProcessCommandLine param (currently it asserts the command is not null or empty), which would skip passing the /cmd arg and effectively make conemu execute whatever is its default session named task.

Therena commented 8 years ago

@hypersw I will check this today evening.

Therena commented 8 years ago

@hypersw I added the possibility to the VS extension to set the default task in the configuration. This is a quick fix for the issue. But I think it would be nicer for the user to have in future the possibility to let the the configuration empty and conemu loads then the default task from the XML configuration.

For now the issue is solved but I would like to let it open until there is a possibility to use the default task from the conemu XML configuration.

Thanks for your help.

Therena commented 8 years ago

@hypersw Seems so that if I set default tasks to the ConsoleProcessCommandLine also other settings are affected.

And the initial working directory does not appear to be set, which is a regression compared to previous versions when using the context-sensitive Open ConEmu menus in solution explorer.

(See comment from PhilipDaniels here: https://github.com/Therena/ConEmuIntegration/issues/6)

Do you know why this could happen or how some fix for this?

PhilipDaniels commented 8 years ago

@Therena

In previous versions of ConEmuIntegration you were explicitly sending a "cd" command to do it.

On 6 July 2016 at 12:48, David Roller notifications@github.com wrote:

@hypersw https://github.com/hypersw Seems so that if I set default tasks to the ConsoleProcessCommandLine also other settings are affected.

And the initial working directory does not appear to be set, which is a regression compared to previous versions when using the context-sensitive Open ConEmu menus in solution explorer. (See comment from PhilipDaniels here: Therena/ConEmuIntegration#6 https://github.com/Therena/ConEmuIntegration/issues/6)

Do you know why this could happen or how some fix for this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Maximus5/conemu-inside/issues/27#issuecomment-230749852, or mute the thread https://github.com/notifications/unsubscribe/ABubRGapKy8esa3du1N7xAmwxS306VWIks5qS5X_gaJpZM4I9LMg .

Philip Daniels.

Therena commented 8 years ago

@PhilipDaniels Which "cd" command? There wasn't any change regarding the cd commands in the last version. The extension only send "cd" commands in case you use the context menu of the solution explorer.