search

Maximus5 / conemu-inside

An example, how to embed http://conemu.github.io/ into another graphical application
57 stars 42 forks source link

Microsoft.Build.Utilities.CommandLineBuilder should be taken from package #29

Open ArsenShnurkov opened 8 years ago

ArsenShnurkov commented 8 years ago

the problem: GitExtension build fails (see here and here), because CommandLineBuilder class is inaccessible.

I propose to exclude it here from sources, and include the reference to package.

https://msdn.microsoft.com/en-us/library/microsoft.build.utilities.commandlinebuilder.aspx Assembly: Microsoft.Build.Utilities.Core (in Microsoft.Build.Utilities.Core.dll)

https://www.nuget.org/packages/Microsoft.Build.Utilities.Core/

This package can be also included into GitExtensions and the problem will be resolved

hypersw commented 8 years ago

Uh-huh, reference whole MSBuild just to escape the commandline properly? I'd rather keep this package simple, this way it makes it easier for use in any projects, without causing MSBuild DLLs appear in the bin dir of any app, or causing DLL hell if the app wants another version of MSBuild. Not a reason enough to cause that.

There's no problem in making the class public as long as its name is changed to something unique which won't interfere with similar classes within the solution which takes this package in.