Maximvdw / MVdWPlaceholderAPI

MVdW Placeholder API
8 stars 15 forks source link

You need to change your version. #6

Closed wyatt-herkamp closed 5 years ago

wyatt-herkamp commented 6 years ago

Next I will update your updater plugin if you allow it.

wyatt-herkamp commented 6 years ago

Sorry for sounding rude. Please accept this. I can't compile Minecoin because I can't get the version 1.9 it does not exist.

wyatt-herkamp commented 6 years ago

BUMP

Kamilkime commented 6 years ago

I agree, I can't add this as a dependency, because of that 1.9 spigot version

wyatt-herkamp commented 6 years ago

I dropped this plugin from my plugin because 1.9 is not a valid version.

Kamilkime commented 6 years ago

I wanted to add it to our plugin, as a hook, but it's impossible right now :/

wyatt-herkamp commented 6 years ago

I could technically upload my fork to my Nexus for a temp fix.

Kamilkime commented 6 years ago

I think I'll wait for the official change. I contacted @Maximvdw on spigotmc, maybe he'll answer :/

wyatt-herkamp commented 6 years ago

I am starting guessing this is never going to get fixed. :(

Kamilkime commented 6 years ago

It starts to look like the author doesn't care :/

wyatt-herkamp commented 6 years ago

I am guessing since this plugin makes no money he doesn't. Actually I am still waiting for support in Featherboard.

wyatt-herkamp commented 6 years ago

28 days later still no comment.

Kamilkime commented 6 years ago

Well, and no commits either - I guess he abandoned the project, at least for now

MiniDigger commented 6 years ago

what if I told you that you can exclude transitive dependencies? https://github.com/VoxelGamesLib/dependencies/blob/6ce32265e159cc628cbdb05319a8e93247f3361c/build.gradle#L44-L46

Kamilkime commented 6 years ago

Well, but still - it would be nice to fix this

HotProtato commented 6 years ago

Please :( I can't mavonize my project until this is fixed -.-

MiniDigger commented 6 years ago

Just exclude the transitive dependency. as you can see Maxim is not looking to bump the minimal Minecraft version.

Kamilkime commented 6 years ago

We don't want it bumped - we want it fixed, because there's no such thing as spigot as an artifact id

MiniDigger commented 6 years ago

thats wrong @Kamilkime, it exist, but not in any public facing repo. if you run buildtools, it builds that version and installs it into your local repo.

as I said, just exclude the transitive dependency...

wyatt-herkamp commented 6 years ago

Later I will upload my fork to my maven repo. This will be public.

MiniDigger commented 6 years ago

or just add 4 lines to your pom/gradle file 😂

wyatt-herkamp commented 6 years ago

No

Kamilkime commented 6 years ago

Well, I think, that if you public something and let people use it as a dependency - it should be ready to use, or at least noted, that you must have spigot in your local repository ;/

wyatt-herkamp commented 6 years ago

I am confused why he is using that Spigot. His plugin doesn't need any @Kamilkime https://gist.github.com/wherkamp/2b3a712f7e654b2849f567afe79be264 Also do you have a Discord?

Kamilkime commented 6 years ago

Yup - with spigot-api everything builds just fine (of course despite the fact, that his updater also has that spigot dependency), so I don't know why can't he just change it to spigot-api 1.9-R0.1-SNAPSHOT.

And if you're asking about my discord - yup, I do have an account, kamilkime#9792

Maximvdw commented 5 years ago

Fixed in latest commit.

wyatt-herkamp commented 5 years ago

After one year. CLAP CLAP