[WIP] Skript Compatibility

[skmedix]

I'll keep this issue up to date, and I'll add more features to the list in next coming days.

Tested with: Skript - dev23 skAliases - 2.0.5 PoreRT - 1.11 build 112 SpongeForge - 1.11-2195-6.0.0-BETA-2004 Forge - 1.11-13.19.1.2199

---

How to reproduce:

1. Install server with Forge, SpongeForge and PoreRT
2. Download and place latest Skript in folder plugins
3. (Optional) Make folder Skript in plugins if it doesn't exist
4. Download and place aliases-english.sk in created folder
5. (Optional) Create folder scripts in Skript folder if it doesn't exist
6. Download problematic skript and place it in folder plugins/Skript/scripts/

7. Run server.

   Tested features:

   • [x] Enabling skripts
   • [ ] Disabling skripts - Error (Problem with guava)
   • [ ] Reloading skripts - Error (Problem with guava)

Effects:

• [ ] Bans - Error - Skript (todo)
• [x] Broadcast
• [ ] Cancel Event (todo)
• [x] Command
• [ ] Damage / Heal / Repair
• [ ] Drop - Error - Skript (todo)
• [ ] Give - Error - Skript give a stone to the player
• [ ] Equip (todo)
• [ ] Exit (todo)
• [ ] Explosion (todo)
• [x] Kick
• [x] Kill
• [x] Lightning
• [x] Messages
• [ ] Op/Deop - Not Implemented PoreHumanEntity.setOp()
• [ ] Open Inventory (todo)
• [ ] Play Effect (todo)
• [ ] Poison (todo)
• [ ] Potion Effect (todo)
• [ ] Push (todo)
• [ ] PvP (todo)
• [ ] Replace (todo)
• [ ] Shear (todo)
• [ ] Shoot (todo)
• [ ] Spawn (todo)
• [ ] Teleport (todo)
• [ ] Toggle (todo)
• [ ] Tree (todo)
• [ ] Vehicle (todo)
• More soon

Events:

• [ ] On Bed Enter - No reaction, No error
• [ ] On Bed Leave - No reaction, No error
• [ ] On Block Damage - No reaction, No error
• [ ] On Break / Mine - MaterialConverter java.lang.NoSuchFieldError: AIR
• [ ] On Bucket Empty - No reaction, No error
• [ ] On Bucket Fill - Error
• [x] On Burn
• [ ] On Can Build Check - (todo)
• [x] On Chat
• [ ] On Chunk Generate
• [x] On Chunk Load
• [x] On Chunk Unload
• [x] On Click - Error - Skript
• [ ] On Combust - (todo)
• [ ] On Command - (todo)
• [ ] On Connect
• [ ] On Consume - (todo)
• [ ] On Craft
• [ ] On Creeper Power - (todo)
• [x] On Damage
• [ ] On Death
• [ ] On Dispense - (todo)
• [ ] On Drop
• [ ] On Enderman/Sheep - (todo)
• [x] On Experience Spawn
• [x] On Explode
• [x] On Explosion Prime
• [ ] On Fade - (todo)
• [ ] On First Join - (todo)
• [ ] On Fishing
• [x] On Flow
• [ ] On Form - (todo)
• [ ] On Fuel Burn
• [ ] On Gamemode Change
• [ ] On Grow
• [ ] On Heal
• [ ] On Hunger Meter Change
• [ ] On Ignition - (todo)
• [ ] On Item Break
• [ ] On Item Spawn
• [x] On Join
• [ ] On Kick
• [x] On Leaves Decay
• [ ] On Level Change - (todo)
• [ ] On Lightning Strike
• [ ] On Move On - Error
• [ ] On Physics
• [ ] On Pick Up - (todo)
• [ ] On Pig Zap - (todo)
• [x] On Piston Extend (w/o sticky)
• [ ] On Piston Retract
• [x] On Place
• [ ] On Portal
• [ ] On Portal Create
• [ ] On Portal Enter
• [ ] On Pressure Plate / Trip
• [x] On Projectile Hit
• [x] On Quit
• [ ] On Redstone - (todo)
• [ ] On Region Enter/Leave - (todo)
• [ ] On Respawn - (todo)
• [ ] On Script Load/Unload - (todo)
• [ ] On Shoot
• [x] On Sign Change
• [x] On Skript Start/Stop
• [ ] On Smelt
• [x] On Sneak Toggle
• [x] On Spawn
• [ ] On Spawn Change - (todo)
• [ ] On Spread - (todo)
• [x] On Sprint Toggle
• [ ] On Tame - (todo)
• [ ] On Target - (todo)
• [ ] On Teleport
• [ ] On Throwing of an Egg
• [ ] On Tool Change
• [ ] On Vehicle Create
• [ ] On Vehicle Damage
• [ ] On Vehicle Destroy
• [ ] On Vehicle Enter
• [ ] On Vehicle Exit
• [ ] On Weather Change
• [ ] On World Init - (todo)
• [x] On World Load
• [x] On World Save
• [x] On World Unload
• [ ] On Zombie Break Door - (todo)
• [x] Periodical

Types: TODO

I'll add more features to the list later, most of them are causing error with MaterialConverter like above.

[Maxqia]

No such field def error probably caused by not updated Sponge version. ItemTypes.AIR was added "recently". And for setOp see here : https://github.com/Maxqia/PoreRT/blob/ed10cae51e66a51fcc46de0d1b03e7d911ac970f/src/main/java/blue/lapis/pore/impl/permissions/PorePermissible.java#L64

[skmedix]

Not implementing setOp makes sense, I think that option is not necessary. Also I've made a small update of the issue. (Most of events doesn't fire any error or message)

Edit: Because most of them are not registered or even implemented, I get it.

[Maxqia]

Implementing events are a royal pain in the butt, so I'd be fine if you just took them from Craftbukkit and turned them into mixins (e.g https://github.com/Maxqia/PoreRT/blob/master/src/main/java/blue/lapis/pore/mixin/network/MixinNetHandlerPlayServer.java), also apparently SpongeForge didn't update the SpongeAPI for the ItemTypes.AIR update until 1.11.2 :P

[skmedix]

I'll look into that.

[bensku]

Is there anything which I (as Skript maintainer) could do to improve Pore compatibility?

[Maxqia]

Probably not from the Skript side of things :P