search

Maxr1998 / MaxLock

Powerful app locker for Android, with a root and no-root implementation
https://maxlock.maxr1998.de
GNU General Public License v3.0
199 stars 45 forks source link

Compatibility with lsposed #157

Open locbox opened 3 years ago

locbox commented 3 years ago

There's a new xposed fork on magisk called Lsposed. This tweak doesn't show up when using Lsposed, can it be updated to be compatible please ?

mario0318 commented 3 years ago

It shows up for me. I can enable it and select the apps to hook into, however the MaxLock app itself just refuses to see the root Xposed framework. But such is the case with the latest EdXposed as well so I'm just really hoping for an update or at least the source to be opened so I can check and maybe find what's causing it to not detect the framework.

1024mb commented 3 years ago

It shows up for me. I can enable it and select the apps to hook into, however the MaxLock app itself just refuses to see the root Xposed framework. But such is the case with the latest EdXposed as well so I'm just really hoping for an update or at least the source to be opened so I can check and maybe find what's causing it to not detect the framework.

That hasn't happened to me, I was using latest EdXposed alpha with MaxLock just fine, I've now installed LSPosed but MaxLock isn't working all the time, sometimes does sometimes it doesn't.

mario0318 commented 3 years ago

So on latest EdExposed both manager and framework MaxLock works fine for you but LSPosed only sometimes?

Do you know if your ROM is odexed or deodexed? And would you mind checking a couple of things for me? If you have a terminal app like Termux or Terminal Emulator, run the following command:

getprop | grep dalvik

This will show the system's prop values containing the term dalvik loaded when your device boots up, in particular the ones with 'dalvik.vm'

You can take a screen shot of the results or simply copy and paste the text. Much appreciated if you can help me with this information! =)

mario0318 commented 3 years ago

It shows up for me. I can enable it and select the apps to hook into, however the MaxLock app itself just refuses to see the root Xposed framework. But such is the case with the latest EdXposed as well so I'm just really hoping for an update or at least the source to be opened so I can check and maybe find what's causing it to not detect the framework.

That hasn't happened to me, I was using latest EdXposed alpha with MaxLock just fine, I've now installed LSPosed but MaxLock isn't working all the time, sometimes does sometimes it doesn't.

Were you able to do that thing in terminal?

1024mb commented 3 years ago

I was mistaken, MaxLock is working well with LSPosed is just that apparently some parts of it aren't, I had to enable de notification to restart the blocking because for some reason MaxLock stopped locking the app once I unlocked it, touching the notification to re-lock works.

RaXorX commented 3 years ago

@1024mb Can you post screenshots or options that you enabled to get it working with LSPosed? What Rom and android version are you on? I was wondering whether there was a way to use it as a native lock screen instead.

1024mb commented 3 years ago

@RaXorX Within the LSposed app you have to enable the module to work with the system framework and also pick the apps you want MaxLock to work with. In MaxLock itself I didn't do nothing else than what I always have done with EdXposed installed which is typical config. The setting to re-enable MaxLock is "Show notification to restart" or something along those lines (app is in Spanish), in the Intika I.mod part of the config.

mario0318 commented 3 years ago

@RaXorX Within the LSposed app you have to enable the module to work with the system framework and also pick the apps you want MaxLock to work with. In MaxLock itself I didn't do nothing else than what I always have done with EdXposed installed which is typical config. The setting to re-enable MaxLock is "Show notification to restart" or something along those lines (app is in Spanish), in the Intika I.mod part of the config.

See, now my issue appears to be beyond what this thread is for, but @1024mb could you possibly do me a real solid favor which would be of immense help. I think with my ROM in particular (which for my device there is only stock and the LOS15.1 I'm using) there is something having to do with the way the system compiles the framework jars and or dex classes where MaxLock appears to be unable to detect the xposed framework, this happens with EdXposed too and yet it didn't use to before EdX devs removed the option to "deoptimize" the boot image. Ever since MaxLock has refused to see xposed. So I'm thinking since the ML dev has seemingly abandoned the app, if i can get the read out of what your working system setup properties for dex and dalvik.vm are then that could give me a clue to maybe it being a simple matter of switching a system prop.

All I'd need is a copy of what your terminal displays when you run "getprop | grep vm"