search

Maxr1998 / MaxLock

Powerful app locker for Android, with a root and no-root implementation
https://maxlock.maxr1998.de
GNU General Public License v3.0
197 stars 45 forks source link

Add gesture locking #81

Open ghost opened 8 years ago

ghost commented 8 years ago

Hi Max,

As discussed on XDA, please check this pull request. Some points to note are

You may want to refactor some stuff as per your preferences, but I have tried to do the best I could. Thanks for your time.

Maxr1998 commented 8 years ago

Very clean code, thanks! I'll look through it in detail in the next days, depending how much time I have; then I'll merge and reformat it a little to my needs :)

ghost commented 8 years ago

You may also want to look at the theme manager's application on the Gesture View, I did not touch it at all.

Maxr1998 commented 8 years ago

@Rijul-Ahuja Theme manager isn't implemented, tbh.. So you don't have to change anything about it ;)

ghost commented 8 years ago

Max, just thought I should mention this, the gesture file isn't encrypted at all, unlike the other modes. If you figure out a way to encrypt the gesture (that is, not just the name, but the actual gesture itself), do let me know, I will implement it in the gesture lockscreen module.

Maxr1998 commented 8 years ago

Thanks! I'll see if I can do it on my own :) I will work on fixing a few things in MaxLock now, and then I'll merge your PR.

Maxr1998 commented 8 years ago

Could you take a look at my line note? Also, could you remove the alternate translations? I think the translators should pick the new strings out on their own.

Maxr1998 commented 8 years ago

Perfect, thanks!

Maxr1998 commented 8 years ago

I decided I won't merge this before next release. I want to have the new release as stable as possible, and out as soon as possible..

ghost commented 8 years ago

Sure, it is your app. Just put up a comment here when you are done so I get to know. PS : Are your translators volunteers you found, or did they find you?

Maxr1998 commented 8 years ago

Of course. I will just tell here. Actually, both. Many are just users who asked to translate, but I also asked one or two of my users to do the translations. BTW, it seems I broke this PR with my last changes (sorry!). Could you take a look at it?

ghost commented 8 years ago

Can you tell me how to look at it? I am not well versed with git. A general idea of what to Google will do, too.

Maxr1998 commented 8 years ago

Well, you have to adapt my changes to your proposes. So you have to pull my updates from my git and then fix the conflicts. I can also do it, but it would be very nice if you could do it :)

Maxr1998 commented 8 years ago

@Rijul-Ahuja Would it be ok for you if I merged this manually? You won't be listed as contributor in the GitHub stats then, but I'll include you in the about screen as sole creator of Gesture lockscreen.

Maxr1998 commented 8 years ago

Also, could you tell me which files you took from the AOSP? Only the ones with the copyright?

Maxr1998 commented 8 years ago

And another question, what is the reason for first extending LockGestureView from GestureOverlayView, then GestureActivityView from LockGestureView? Can't I just merge the non-AOSP views?

ghost commented 8 years ago

Sorry, I totally forgot about this commit.

  1. Manual works, I don't mind. If there is a link, please link to fb.com/rijul.ahuja
  2. No files from AOSP, they are from Temasek. https://github.com/temasek/android_frameworks_base/commit/d89f57baa936d6c2114e1a3726ca4f4f8f2b2437 and https://github.com/temasek/android_packages_apps_Settings/commit/8fea9e778259df367066c2e74708dedc6498ff87
  3. LockGestureView is used in the GestureSetupFragment and GestureActivityView is used in the lock activity, because they use different methods of authentication. (GestureSetupFragment saves in the gesture file, while the GestureActivityView calls the parent activity to match the gesture, like you do with the knock code and stuff, using an authenticationSucceededListener).

Can't I just merge the non-AOSP views? I don't understand what this means.

Maxr1998 commented 8 years ago
  1. Sure, will add that link.
  2. Thanks, then I'll mention them in the credits.
  3. Ah, I see, silly me. Then of course you need different views.

Forget about my other request, basically wanted to merge fragment and activity code, which doesn't work.

ghost commented 8 years ago

Any movement on this, Max?

Maxr1998 commented 8 years ago

Yeah, I will add it next when I find time for MaxLock again