Maxr1998 / ModernAndroidPreferences

Android Preferences defined through Kotlin DSL, shown in a RecyclerView
Apache License 2.0
120 stars 5 forks source link

:sparkles: Support custom badge colors and badges in dialog preferences #140

Closed rosenpin closed 1 year ago

rosenpin commented 1 year ago

TODO:

rosenpin commented 1 year ago

Accidentally added option to change badge color as well, you can drop the last commit if you don't want to include that

rosenpin commented 1 year ago

If it's ok for you, I would do some formatting tweaks myself after you fixed my one comment here, that's easier than having to write a lot of suggestions in this review.

Sure sounds good

Maxr1998 commented 1 year ago

Btw, you might need to rebase your PR onto the latest master to pass the updated check workflows.

rosenpin commented 1 year ago

Btw, you might need to rebase your PR onto the latest master to pass the updated check workflows.

Thanks, done

rosenpin commented 1 year ago

Added deprecation warning and also updated usage in example app that I realized I forgot to change till now

rosenpin commented 1 year ago

🙃

Maxr1998 commented 1 year ago

I think we might need another rebase to drop the already applied commits :grimacing:

If that's ok for you, I'll do that, and then merge.

rosenpin commented 1 year ago

Thanks man you're great! It's looking much better now, sorry for not making it easier for you
And of course, you can go ahead and rebase it as much as you want, it's your repo :P