Maxstupo / ydl-ui

A UI for the command-line video downloader "youtube-dl"
MIT License
363 stars 35 forks source link

2 issues with stop #113

Closed ZX-Commodore-ST closed 10 months ago

ZX-Commodore-ST commented 1 year ago

Describe the bug

  1. Stop doesn't really stop. It still downloads file in the background. When I open log it's clear to see it's still downloading.
  2. Sometimes it crashes YDL-UI after I try to stop downloading a file.

Expected behavior Immediate stop. Instant terminate/kill youtube downloader if needed.

Information (please complete the following information)

Maxstupo commented 10 months ago

This is most likely something to do with ytdl-patched refusing to close. Stop in ydl-ui forces the download process to close (see here).

If you are using a custom downloader for ytdl-patched such as aria2, that also might be the cause.

Closing, since nothing can really be done within ydl-ui.