Maxstupo / ydl-ui

A UI for the command-line video downloader "youtube-dl"
MIT License
354 stars 34 forks source link

Clearer Display for ETAs of Long Estimate Downloads #33

Closed hl2guide closed 5 years ago

hl2guide commented 5 years ago

Please consider improving the display for downloads that have an ETA over 1 hour.

Currently it is like: screen

Shouldn't it have :00 on the end to denote seconds as a unit?

Maxstupo commented 5 years ago

Currently, Progress, Size, Speed, and ETA are all directly fetched from youtube-dl output. If I'm not mistaken the ETA is in mm:ss format.

hl2guide commented 5 years ago

hmm, might be worth looking into it as there is no way that I can download about 5GB in 1 minute and 53 seconds on a 11Mbps connection (lame ADSL2+ connection in Australia).

Maxstupo commented 5 years ago

It looks like youtube-dl outputs in hh:mm:ss only when the download time is above one hour, else mm:ss.

hl2guide commented 5 years ago

Makes sense. next time I'm downloading a big YouTube video I'll show more screenshots (results).

hl2guide commented 5 years ago

Another example of this issue: example

Maxstupo commented 5 years ago

Made the ETA column only output hh:mm:ss

hl2guide commented 5 years ago

wonderful thanks 🍰