Maxstupo / ydl-ui

A UI for the command-line video downloader "youtube-dl"
MIT License
354 stars 34 forks source link

Period of automatic check strings seems not translated #60

Closed bovirus closed 4 years ago

bovirus commented 4 years ago

@Maxstupo

Describe the bug A clear and concise description of what the bug is.

The progranm at first startup seems didn't detect Italin SO and didn'ts etup UI in italian.

In the drop down list of period for automatic check the strings seems are not localized. Please check the screnshot.

To Reproduce Steps to reproduce the behavior (if applicable, attach preset file):

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Information (please complete the following information)

Additional context Add any other context about the problem here.

YDL-UI-2 6 6-01

Maxstupo commented 4 years ago

https://github.com/Maxstupo/ydl-ui_i18n/commit/72042c5844acab95526e22729c32990ce9d83e31

bovirus commented 4 years ago

@Maxstupo

Italian language update.

What's about Windows OS language check? At first startup the program should detect OS language and if it Italian OS detected should set/start automatically with italian language.

In my configuration (Windows 10 x64 Italian) the program at first startup start in English.

Maxstupo commented 4 years ago

@bovirus

Has this just occurred with v2.6.6 or has it been a problem with previous versions also?

bovirus commented 4 years ago

I will check.

Which is the path & filename for settings/ini file?

Maxstupo commented 4 years ago

If you set the language using the settings window it won't auto-detect the OS language on start.

The settings file is ydl-ui.json it's in the same folder as the application. Try setting the language entry to be empty, this should cause YDL-UI to detect the OS language on application startup.

   "Language": "",
Maxstupo commented 4 years ago

I think I have found the bug, try YDL-UI_v2.6.6.3_Portable and see if it detects the language on start.

bovirus commented 4 years ago

@Maxstupo

Thanks. Fixed. I confirmed that v. 2.6.6.3 detect Italian OS and start in Italian.

bovirus commented 4 years ago

@Maxstupo

I hope to see soon the new version with languages updated and fix for Italian OS check.