Maxwell777 / gprivacy

Automatically exported from code.google.com/p/gprivacy
0 stars 0 forks source link

No option to disable the context menu entry #10

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What version of the product are you using: 0.2.3
With what browser and browser version:     Firefox Aurora 25.0a2
On what operating system:                  Lubuntu Linux 12.04

Report a problem:

What steps will reproduce the problem?
  1. Install gprivacy
  2. Load a page which causes it to take effect
  3. Right-click

What is the expected output? What do you see instead?
  I expect to see only context menu entries that are actually contextual. (eg. HistoryBlock's "Block This!" (add this site to the blacklist) option)
  Instead, I see a needless duplicate of the gprivacy "Preferences" button from about:addons.

gprivacy needs a checkbox in the "gPrivacy Preferences" dialog to disable the 
context menu entry.

I put a lot of work into clearing clutter out of my context menu (going so far 
as to tease apart the StumbleUpon extension to figure out what IDs I needed to 
"display: none" in my XUL userstyles) and, since I'm feeling too drained to dig 
through your source code to figure out what the ID is for that entry, I just 
disabled the extension instead.

Original issue reported on code.google.com by stephan....@gmail.com on 5 Oct 2013 at 4:08

GoogleCodeExporter commented 9 years ago
The context menu _is_  contextual. I.e., it only shows on pages where GP is 
active.

Nonetheless, such an option would, of course, be an option.
But then, again, it clutters the options even more ;-)

Original comment by hhofe...@googlemail.com on 7 Oct 2013 at 2:51

GoogleCodeExporter commented 9 years ago
Context-dependant display isn't contextual enough to meet my definition. The 
action performed must be contextual enough to at least vary depending on the 
active tab.

Since I'm more alert now, I did a little repo diving and I'll be adding a 
"gPrivacy - Remove non-contextual context menu entry" style to userstyles.org 
as soon as my OpenID provider stops hiccuping.

Original comment by stephan....@gmail.com on 7 Oct 2013 at 7:31

GoogleCodeExporter commented 9 years ago
> Context-dependant display isn't contextual enough to meet my definition.
> The action performed must be contextual enough to at least vary depending on 
the active tab.

Well, that's exactly what it already does: Unless, of course, every of your 
tabs is on a Google-, Yahoo-, Bing- or facebook-page, you should see the 
difference...
(code.google.com, BTW, _is_ a Google-page)

Original comment by joh...@gmail.com on 7 Oct 2013 at 8:29

GoogleCodeExporter commented 9 years ago
How does "show the Preferences dialog" differ depending on which tab it's 
called from?

Also, while I had to change the name to fit within the allowed length, my 
userstyle workaround is now up.

(For the benefit of any users like me who wander in, it's at 
http://userstyles.org/styles/93773/gprivacy-hide-non-contextual-context-menu-ent
ry )

Original comment by stephan....@gmail.com on 7 Oct 2013 at 10:24

GoogleCodeExporter commented 9 years ago
> How does "show the Preferences dialog" differ depending on which tab it's 
called from?

Now you lost me...

I thought you are talking about the context menu on web pages (right click).
The 'gPrivacy Options...' item only appears on pages (tabs or windows) where a 
supported site is displayed.
Otherwise, the context-menu-item is _not_ shown (try http://www.wikipedia.org/ 
;-) ).

Which means: In the context of a supported URL, it is possible to change GPs 
options from the context-menu, too. In general you have to go to the add-on or 
privacy settings, though.

This also serves as an indicator that you are, in fact, on a supported site (or 
a site that has e.g. a Google search embedded).

Adding additional sub-menus would not add any functionality (e.g. 'Disable for 
Google') and require only one click less than going through the preferences 
dialog.

But as I said in comment #2, it should be possible, it's just not a high 
priority.
But since you are the first to request this 'feature' and you were able to 
solve it yourself using a user-style, I might consider closing this ticket as 
'WontFix', if there are no more requests for this.

I could also link to your user-style from the add-on home page...

Original comment by hhofe...@googlemail.com on 7 Oct 2013 at 11:07

GoogleCodeExporter commented 9 years ago
> > How does "show the Preferences dialog" differ depending on which tab it's 
called from?
> 
> Now you lost me...

I said "The action performed must be contextual enough to at least vary 
depending on the active tab." and you said "Well, that's exactly what it 
already does"

How does "show the Preferences dialog" (the action that is triggered by 
clicking on the option) behave differently depending on which tab you trigger 
it from?

> This also serves as an indicator that you are, in fact, on a supported site 
(or a site that has e.g. a Google search embedded).

That's what toolbar buttons which change between coloured and grayscale are for 
(I keep about half a dozen of them in my Add-On Bar which I can toggle with 
Ctrl+/ ) and, as a bonus, you get a free "Customize..." dialog that lets users 
add or remove them.

> Adding additional sub-menus would not add any functionality (e.g. 'Disable 
for Google') and require only one click less than going through the preferences 
dialog.

If it were made into a toolbar button, I could see benefit to having it trigger 
a popup menu with "Preferences..." and "Reload without protection" in it. (The 
latter being roughly analogous to NoScript's "temporarily allow all")

However, given my views on privacy extensions, I'm honestly not sure there's 
any feature you could implement which would justify a context menu. (I have 
over half a dozen privacy-related extensions installed and the only entries I 
allow them to add to my context menu are HistoryBlock's "Block This!" and 
PrivateTab's "Open link in New Private Tab".)

> I could also link to your user-style from the add-on home page...

Now that the idea of converting it into a toolbar button has occurred to me, I 
think I'd prefer that... but I'd also accept linking to my userstyle from the 
home page as a solution.

Original comment by stephan....@gmail.com on 7 Oct 2013 at 11:28

GoogleCodeExporter commented 9 years ago
gprivacy is a great addon.
Can you please make an option to change background-color or/and text color 
,something like:
a[title="Privacy Respected!"]
 {
    background-color: #008000;
}

Original comment by paul.bel...@gmail.com on 4 Feb 2015 at 4:25