search

MaxwellBo / Muncoordinated-2

🇺🇳 Muncoordinated is a Model UN committee management service, (re)written with TypeScript, React, Semantic UI and Firebase.
https://muncoordinated.io/
GNU General Public License v3.0
33 stars 21 forks source link

Migrate off Heroku onto Netlify #87

Closed MaxwellBo closed 4 years ago

MaxwellBo commented 4 years ago

Current state of the build on Netifly:

8:01:02 PM: $ yarn build
8:01:02 PM: yarn run v1.22.4
8:01:02 PM: $ react-scripts build
8:01:04 PM: Creating an optimized production build...
8:01:06 PM: Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade`
8:02:20 PM: 
8:02:20 PM: Treating warnings as errors because process.env.CI = true.
8:02:20 PM: Most CI servers set it automatically.
8:02:20 PM: 
8:02:20 PM: Failed to compile.
8:02:20 PM: 
8:02:20 PM: ./src/components/Files.tsx
8:02:20 PM:   Line 143:13:  The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid
8:02:20 PM:   Line 144:36:  The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid
8:02:20 PM:   Line 160:23:  The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid
8:02:20 PM:   Line 162:13:  The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid
8:02:20 PM:   Line 183:13:  The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid
8:02:20 PM: ./src/components/Auth.tsx
8:02:20 PM:   Line 221:45:  'renderSuccess' is assigned a value but never used                                                                                                                                                                                                                                                                                                                       @typescript-eslint/no-unused-vars
8:02:20 PM:   Line 318:13:  The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid
8:02:20 PM: ./src/components/Motions.tsx
8:02:20 PM:   Line 25:8:  '_' is defined but never used  @typescript-eslint/no-unused-vars
8:02:20 PM: ./src/components/Strawpoll.tsx
8:02:20 PM:   Line 2:13:    '_' is defined but never used                                          @typescript-eslint/no-unused-vars
8:02:20 PM:   Line 224:11:  Expected an assignment or function call and instead saw an expression  no-unused-expressions
8:02:20 PM: ./src/components/Timer.tsx
8:02:20 PM:   Line 3:67:    'ButtonProps' is defined but never used    @typescript-eslint/no-unused-vars
8:02:20 PM:   Line 63:34:   Missing '()' invoking a constructor        new-parens
8:02:20 PM:   Line 63:57:   Missing '()' invoking a constructor        new-parens
8:02:20 PM:   Line 181:57:  'tick' is assigned a value but never used  @typescript-eslint/no-unused-vars
8:02:20 PM: ./src/components/Caucus.tsx
8:02:20 PM:   Line 3:8:  '_' is defined but never used  @typescript-eslint/no-unused-vars
8:02:20 PM: ./src/components/Homepage.tsx
8:02:20 PM:   Line 454:19:  Emojis should be wrapped in <span>, have role="img", and have an accessible description with aria-label or aria-labelledby  jsx-a11y/accessible-emoji
8:02:20 PM: ./src/components/Stats.tsx
8:02:20 PM:   Line 4:8:  'Committee' is defined but never used  @typescript-eslint/no-unused-vars
8:02:20 PM: ./src/components/Footer.tsx
8:02:20 PM:   Line 54:13:  'latestVersion' is assigned a value but never used  @typescript-eslint/no-unused-vars
8:02:20 PM: ./src/utils.ts
8:02:20 PM:   Line 64:43:  Expected '===' and instead saw '=='  eqeqeq
8:02:20 PM:   Line 64:59:  Unexpected mix of '&' and '|'        no-mixed-operators
8:02:20 PM:   Line 64:65:  Unexpected mix of '&' and '|'        no-mixed-operators
8:02:20 PM: ./src/components/Onboard.tsx
8:02:20 PM:   Line 6:23:  'List' is defined but never used        @typescript-eslint/no-unused-vars
8:02:20 PM:   Line 8:25:  'Dictionary' is defined but never used  @typescript-eslint/no-unused-vars
8:02:20 PM: ./src/components/Resolution.tsx
8:02:20 PM:   Line 7:59:   'Checkbox' is defined but never used       @typescript-eslint/no-unused-vars
8:02:20 PM:   Line 8:102:  'DropdownProps' is defined but never used  @typescript-eslint/no-unused-vars
8:02:20 PM: ./src/components/Admin.tsx
8:02:20 PM:   Line 82:36:  'absCanVote' is assigned a value but never used  @typescript-eslint/no-unused-vars
8:02:20 PM:   Line 82:59:  'nonNGONo' is assigned a value but never used    @typescript-eslint/no-unused-vars
8:02:20 PM: ./src/components/caucus/SpeakerFeed.tsx
8:02:20 PM:   Line 9:35:  'FeedContent' is defined but never used  @typescript-eslint/no-unused-vars
8:02:20 PM: ./src/components/Committee.tsx
8:02:20 PM:   Line 9:94:  'Divider' is defined but never used  @typescript-eslint/no-unused-vars
8:02:20 PM: error Command failed with exit code 1.
8:02:20 PM: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
8:02:20 PM:

Either

  1. Suppress these errors individually on each lin @ts-ignore
  2. Fix the errors
  3. Stop process.env.CI = true. from treating warnings as errors
MaxwellBo commented 4 years ago

This is almost done! I'm just waiting a day for the DNS records for the Heroku service to peter out now that I've swapped over to Netlify, turn down Heroku and then I'll mark this complete.