Maxx53 / SCMBot

Steam Community Market auto-buying bot
http://scmbot.com
GNU General Public License v2.0
237 stars 116 forks source link

"Load Html instead Json" feature for Item Page #146

Open Maxx53 opened 10 years ago

Maxx53 commented 10 years ago

image Slower, but more stable method. Please test it.

P.S. Works only with Item Page tab. Do not try to items with new "buy orders" interface.

berberitos commented 10 years ago

works 100 times better than the old version, great work max!!

l4m0r commented 10 years ago

Works good, thanks :)

Can you tro to implement it in a way that it doesn't affect newly listed (if I use this setting I get "parsing fail" on newly listed all the time) tho, please?

Maxx53 commented 10 years ago

@l4m0r Sure, my bad.

Maxx53 commented 10 years ago

Fixed

l4m0r commented 10 years ago

Thanks. Would you be so kind to update the binaries, too? I can't compile it myself at the moment, no access to VS.

kitzik commented 10 years ago

hmmm... Parsing fail all the way on Item Page tab when Scan HTML is on

Maxx53 commented 10 years ago

@kitzik Not working with "buy orders" items.

UgaBugaBoo commented 10 years ago

@Maxx53 On the newly listed there are random 500ms-1000ms delay. However, the most important part is there is not Caching anymore :D

l4m0r commented 10 years ago

I noticed one new bug:

When using Scan HTML is ON, Newly listed is working a lot slower than with the HTML option being off (1 refresh in 3 seconds instead of 1 refresh in 1 seconds).

Also I agree with sabbir, would be great if you could make the random delays a bit smaller, so it still doesn't cache but gets more items.

Maxx53 commented 10 years ago

There's one thread now, html loads slower. If you want to scan Page and Listed at the same time, requests will be queued.

UgaBugaBoo commented 10 years ago

Well hats off to you mate @Maxx53 you have done a great job this time, It seemed it was nearly impossible to stop the caching, but you figured it out. I admire your project and your contribution to the community.

Just ignore us when we seem like too greedy and needy.

UgaBugaBoo commented 10 years ago

Well it was working for a while, but the item page gives me "Jason without data" throughout the result. as @kitzik already mention. And the items I tested on are "key"s.

l4m0r commented 10 years ago

Okay, I understand Maxx53. Thanks for the explanation :)

I have one more idea/request tho: I'm sure it is possible to scan items with json (without getting json without data) problem, so I think html function is not really required.

I still scan item pages with old commit without errors (latest commit that you released before steam market was updated). I merely replaced item link with this: http://steamcommunity.com/market/listings/730/StatTrak%E2%84%A2%20AK-47%20%7C%20Vulcan%20%28Factory%20New%29?country=DE&language=english&currency=3&count=10

I can scan all day without getting "json without data", but with newer commits I get it.

/edit: Apparently adding language and currency fixes the "getting json without data problem", if I add it I can scan on new commit without that problem, too. :-)

UgaBugaBoo commented 10 years ago

@l4m0r where can I add this string for compilation ?

l4m0r commented 10 years ago

Nvm, I posted too early. It got less (at least thats what I feel) but it didnt fix it :(

I just search for this instead of http://steamcommunity.com/market/listings/730/StatTrak%E2%84%A2%20AK-47%20%7C%20Vulcan%20%28Factory%20New%29, put it right into item link textbox... not in the source code. It was needed in the old compiles before Maxx updated SCM after the Steam Market Update.

UgaBugaBoo commented 10 years ago

Scored 2 higher teir items in 24 hours. :D

l4m0r commented 10 years ago

Can confirm it is working good :)

firebug11 commented 9 years ago

@Maxx53 Has this feature been removed, becuase i dont have that button on settings :s

nimabrave999 commented 9 years ago

@firebug11 you sure??

firebug11 commented 9 years ago

untitled2 @nimabrave999 Yep

nimabrave999 commented 9 years ago

@firebug11 you get this through the binary files download?