nus-se-script
commented
1 day ago [IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]
Team's Response
Thank you for raising this concern. However, I think there has been a misunderstanding. Just to reiterate, our application is designed to help car rental companies handle and track car rental details. Therefore, the price of the car would refer to the rental price of the car. I figured you might have mistook our app as a car dealership app that sells cars or something along those lines, and as a result interpreted the price as the selling price of the car.
According to Google, the average car rental price in Singapore is only around $120 per day. As such, after discussing with my team, we feel that setting a limit of $10000 for the car rental price is rather reasonable. Perhaps it could even be lower than $10000 too.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Unnecessary validation when adding a car
When the user adds a car, the price cannot exceed 10000, which may be not realistic enough. Perhaps giving a warning to the users rather than just blocking the input will be better?
[original: nus-cs2113-AY2425S1/pe-interim#761] [original labels: type.FeatureFlaw severity.Low]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thank you for raising this concern. However, I think there has been a misunderstanding. Just to reiterate, our application is designed to help car rental companies handle and track car rental details. Therefore, the price of the car would refer to the rental price of the car. I figured you might have mistook our app as a car dealership app that sells cars or something along those lines, and as a result interpreted the price as the selling price of the car.
According to Google, the average car rental price in Singapore is only around $120 per day. As such, after discussing with my team, we feel that setting a limit of $10000 for the car rental price is rather reasonable. Perhaps it could even be lower than $10000 too.
Next, thank you for including suggestion(s) for improvements too. To address that, as the current version of our app doesn't support editing any records directly, my team and I feel that it is better to block the input and show an error message instead. This is because for instance, suppose the user wants/needs to edit the record details, he/she needs the delete the current record and enter a new record with the correct details, which can be cumbersome. As a result, any input which is deemed invalid will be blocked off/rejected.
However, in future versions where we do implement support for editing record details, your suggestion will actually work. In that case, since users are able to edit the record details anyways, the app could just issue a warning to the users, while still treating it as a valid input rather than blocking it off entirely.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
May not work with many users as car-prices are always much higher than 10000 Reference: As a result, COE prices fluctuate and can range from $0 to over $100,000. When purchasing a car in Singapore, the initial cost can be steep. For instance, a sedan typically costs around S$120,000, while a small SUV/crossover costs S$135,000, and a luxury car can set you back around S$190,000.15 Dec 2023