search

MayaPosch / MQTTCute

An advanced desktop MQTT client, suitable for binary protocol development and monitoring
BSD 3-Clause "New" or "Revised" License
64 stars 13 forks source link

Received PUBLISH not aligned #2

Open MrAureliusR opened 5 years ago

MrAureliusR commented 5 years ago

When subscribing to a topic that returns a longer string, the output does not scale to the window width. Also, when there is a line break, the alignment between bytes and ASCII gets thrown off: screenshot from 2019-02-28 03 16 55

Ideally, the spacing between the bytes/ASCII would scale with window width. If this isn't possible, then when there is a line break there should be an attempt to align the ASCII with the previous line.

MayaPosch commented 5 years ago

I made a few tweaks to the code so that the alignment should look a lot better. Please have a look and see what you think.

The main issue was with the fact that monospace fonts do not have monospace whitespace. This should be solved now with the use of U+2007 (Figure Space) instead of a plain space for padding.

MayaPosch commented 5 years ago

As for the number of bytes/characters per line, this can be changed as well. Would having this change dynamically with window resize work better than being able to specify the byte count globally or per window?

I can see a few different use cases here that should be considered.

MrAureliusR commented 5 years ago

As for the number of bytes/characters per line, this can be changed as well. Would having this change dynamically with window resize work better than being able to specify the byte count globally or per window?

I think that in most cases, people will dynamically resize until they get a nice, neat display. Though having fixed width could also be handy... Just pulled and built 318104a and noticed that topic windows now seem to have a fixed width: screenshot from 2019-03-03 17 00 54 However the discovery windows do not: screenshot from 2019-03-03 17 01 40 Not sure if that was intentional or not?

I seem to be getting the subscribed data in a single column now: screenshot from 2019-03-03 17 05 10

MayaPosch commented 5 years ago

Could you retest this with the current v0.3-alpha version?

MayaPosch commented 5 years ago

During testing of a current commit I also stumbled over this alignment issue with everything on the left side. Changing the text widget to a QPlainTextWidget seems to have fixed this.

The further cosmetic tweaking/resizing of the MDI windows is still TODO.