MayamaTakeshi
commented
1 year ago I tried to use the latest https://github.com/Ilogeek/redmine_issue_dynamic_edit commit:
$ git log |head -n 5
commit 17714c542b39b67ad5b061bfbb64d2c000fcd64c
Author: Hugo Zilliox <hello@hzilliox.fr>
Date: Tue Dec 27 23:58:11 2022 +0100
JSToolbar fixed (#100)But I get this error constantly in the web console:
Error: Error occured:
checkVersion http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682683385:328
promise callback*checkVersion http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682683385:306
checkVersionInterval http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682683385:342
setInterval handler*setCheckVersionInterval http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682683385:341
<anonymous> http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682683385:350The redmine_rt plugin is not installed. Which version of redmine_issue_dynamic_edit are you using?
UPDATE: The above problem was caused because I got this in my redmine URL
http://192.168.225.201:3000/issues/19?tab=historySo in client javascript I have LOCATION_HREF="http://192.168.225.201:3000/issues/19?tab=history" But the code in issue_dynamic_edit.js has this:
fetch(LOCATION_HREF + ".json", {
method: 'GET',
crossDomain: true,
}).then(res => res.text()).then(...)So it would try to get
http://192.168.225.201:3000/issues/19?tab=history.jsonwhich of course would fail. I added code to clean up the LOCATION_HREF:
let clean_url = (url) => {
let nu = new URL(url);
return `${nu.protocol}//${nu.host}${nu.pathname}`;
}
let LOCATION_HREF = typeof custom_location_href !== 'undefined' ? custom_location_href : clean_url(window.location.href);and then this issue was solved and i could see the issue details being updated in realtime. But this work only for one change as there is another problem:
Uncaught TypeError: Node.appendChild: Argument 1 is not an object.
onreadystatechange http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682748498:412
updateIssue http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682748498:377
sendData http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682748498:443
checkVersion http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682748498:325
promise callback*checkVersion http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682748498:306
sendData http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682748498:441
getEditFormHTML http://192.168.225.201:3000/plugin_assets/redmine_issue_dynamic_edit/javascripts/issue_dynamic_edit.js?1682748498:94
issue_dynamic_edit.js:412:53The above happens no matter if the LOCATION_HREF is clean or not. There is an error in this line:
As the result of
doc.querySelector('#history .journal.has-details:last-child')is null.
However, since you are not seeing these problems probably you are using a different or a patched version of this plugin.
Anyway, since I can see the issue, I have created an PR: https://github.com/Ilogeek/redmine_issue_dynamic_edit/pull/110
Also this explains the journal being added in duplicity. Because in fact, any change in journals will be notified and updated by redmine_rt (journals are not only notes, but changes in properties too). However, the above code in redmine_issue_dynamic_edit is doing the same thing after it changes something. So that is why you see that journal being added two times. (this could be solved by modifying redmine_issue_dynamic_edit to check if redmine_rt is present, and if yes, to ignore the update of the notes. This should not be difficult to do but since it is not critical and I have very limited time to work on redmine tasks I will not prepare a PR for it yet).
AndreySolod
Hi, I find some another Incompatibles with plugins: 1) Incompatibles with redmine_issue_dynamic_edit - when Issue updated by redmine_rt, Redmine itself begins to believe that someone else has updated the task and shows the following picture:
And when Issue updates via issue_dynamics_edit the plugin adds 2 entries about this to the "notes" tab, although it should not add any:
2) With plugins redmine_hearts: sometimes He just stop working with next error:
and when he add the comment, comment does not have a heart - we need to refrest the page:(