search

MayamaTakeshi / redmine_rt

Redmine plugin for Real-Time notification of events
GNU General Public License v3.0
24 stars 4 forks source link

Added note ID is always 1. #47

Closed sk-ys closed 12 months ago

sk-ys commented 12 months ago

Screenshot

image

My environment as follows:

Environment:
  Redmine version                5.1.0.devel
  Ruby version                   3.1.4-p223 (2023-03-30) [x64-mingw-ucrt]
  Rails version                  6.1.7.6
  Environment                    development
  Database adapter               PostgreSQL

My guess is that the same error occurs in Redmine 4.1 and later. In this line, $history_children has div.tabs and div#tab-content-history.

var $history_children = $history.find("> div");

https://github.com/MayamaTakeshi/redmine_rt/blob/master/assets/javascripts/channels/issue_channel.js#L182 However, you probably wanted to get div.journal instead.

Page Source

image

Browser console

image
MayamaTakeshi commented 12 months ago

Indeed. I didn't notice it because the issue happened only in case of "Display comments" = "In chronological order"
which I was not using. Thanks.