search

Mayank0255 / Stackoverflow-Clone-Frontend

Clone project of a famous Q/A website for developers built using MySQL, Express, React, Node, Sequelize :globe_with_meridians:
https://stackoverflow-clone-client.vercel.app
MIT License
546 stars 209 forks source link

feat(#23): Making the app responsive #26

Closed di10 closed 3 years ago

di10 commented 3 years ago

This PR addresses to issue #23

Mayank0255 commented 3 years ago

Can you please add some screenshots of the page in different screen sizes?

Would make my job easier to review it

di10 commented 3 years ago

Homepage

localhost_3000_ (2) localhost_3000_ (1) localhost_3000_ localhost_3000_ (4) localhost_3000_ (3)

di10 commented 3 years ago

Register

localhost_3000_ localhost_3000_ (1)

Mayank0255 commented 3 years ago

Good work👍

I have some points that needs to be worked on still-

  1. Add some data(like posts with different tags and creating some more users) and then try out the responsiveness

  2. The sidebar should go all the way down

  3. After adding the data you will be required to make the tags page, users page, single tag page, profile page, Post page and Postform page also responsive.

Note - while adding a question add only one tag not more than that as multiple tags are not functional right now.

@di10 All the best for the task and kudos to you for the work you have done till now

di10 commented 3 years ago

Homepage

localhost_3000 localhost_3000_

di10 commented 3 years ago

Postform page

localhost_3000_ (1) localhost_3000_

di10 commented 3 years ago

Tags Page

localhost_3000_ (1) localhost_3000_

di10 commented 3 years ago

Single Tag Page

localhost_3000_ (1) localhost_3000_

di10 commented 3 years ago

Post Page

localhost_3000_ (1) localhost_3000_

di10 commented 3 years ago

Users Page

localhost_3000_ (1) localhost_3000_

di10 commented 3 years ago

Profile Page

localhost_3000_ (2) localhost_3000_

Mayank0255 commented 3 years ago

@di10 Everything seems good apart from some things -

  1. Action buttons such as Search Button and Menu Button on click should come on top for better traversal as currently they coming in the bottom of the page which is not a good practice.

  2. In the PostForm page remove the image which is near the title "Ask a question" when the media query reduces such that it does not overlaps with the text.

Mayank0255 commented 3 years ago

@di10 One more thing that I have committed on the master branch so pull from the upstream and then move forward with the work

Mayank0255 commented 3 years ago

@di10 Let me know if you are working on this or not, as I will have to close the pr then.

Mayank0255 commented 3 years ago

@di10

Create a new PR and reference this one too in that when you have made any progress with the work