search

Mayank0255 / Stackoverflow-Clone-Frontend

Clone project of a famous Q/A website for developers built using MySQL, Express, React, Node, Sequelize :globe_with_meridians:
https://stackoverflow-clone-client.vercel.app
MIT License
543 stars 207 forks source link

feat(#2): implement pagination component and add it to pages #57

Closed luko0610 closed 2 years ago

luko0610 commented 2 years ago

Implemented pagination component and added it to the following pages:

Mayank0255 commented 2 years ago

@luko0610 There are some conflicts as I recently merged a PR, so kindly pull it to your forked repo and then commit.

Mayank0255 commented 2 years ago

@luko0610 Another thing that can you send me screenshots of how the pagination is looking after you implemented them? and is it responsive as well?

It would be really helpful in reviewing it that way

luko0610 commented 2 years ago

@Mayank0255 image image

If already on last page the next button is disabled. Should also be responsive.

Mayank0255 commented 2 years ago

@luko0610 try this out for the styling of the components https://stackoverflow.design/product/guidelines/using-stacks/

This is officially provided by stackoverflow and the basic setup has already been done and used in some places, so you can just use this. Like you can use this for the buttons, so that it matches exactly with the real one

Mayank0255 commented 2 years ago

@luko0610,

I had a request to make that as Hacktoberfest has only one week left, I am planning to do a tweet on twitter at the end of the month congratulating all the contributors and giving them a special mention for there efforts,

To do this I would like you to do the steps below so that it becomes easy for me to document,

  1. Follow me on Mayank0255
  2. Text me on twitter itself so that I have your twitter handles.
  3. In the text mention three things-
    • Github Handle Link
    • Name of the project you worked with me

I hope to receive a favorable reply 🎉

Mayank0255 commented 2 years ago

@luko0610,

I had a request to make that as Hacktoberfest has only one week left, I am planning to do a tweet on twitter at the end of the month congratulating all the contributors and giving them a special mention for there efforts,

To do this I would like you to do the steps below so that it becomes easy for me to document,

  1. Follow me on Mayank0255
  2. Text me on twitter itself so that I have your twitter handles.

  3. In the text mention three things-

    • Github Handle Link
    • Name of the project you worked with me

I hope to receive a favorable reply 🎉

@luko0610 Any updates on this?