Mayank0255 / Stackoverflow-Clone-Frontend

Clone project of a famous Q/A website for developers built using MySQL, Express, React, Node, Sequelize :globe_with_meridians:
https://stackoverflow-clone-client.vercel.app
MIT License
541 stars 206 forks source link

[Frontend]: Add Spinners To All Actionable Buttons #85

Open Mayank0255 opened 2 years ago

Mayank0255 commented 2 years ago

Add spinners to all buttons so that when the user clicks a button, it shows a spinner and the user gets to know that some process is going on

shravankumar-fs commented 2 years ago

Hey Mayank Could you assign this to me? I'd like to assist on this?

Also can i use this without setting up the backend locally?

Mayank0255 commented 2 years ago

@shravankumar-fs Actually backend would be required, otherwise from where will you be getting all the data and test properly.

Let me know if you are in to take up this issue, will assign it to you then

Mayank0255 commented 2 years ago

And this might help for loading buttons, https://stackoverflow.design/product/components/buttons/#loading

Mayank0255 commented 1 year ago

@shravankumar-fs

Found a workaround to avoid setting up backend, Can just change the url here to this https://stackoverflow-clone-backend.herokuapp.com

Let me know if you are interested and would want me to assign it to you

shravankumar-fs commented 1 year ago

Hi @Mayank0255 Please assign it to me, I'll do.

Also currently which buttons need this feature?

I see some places with no action event being triggered

Mayank0255 commented 1 year ago

@shravankumar-fs Ya sure, go ahead.

So, spinners will be required wherever an api call is going, like when the components of a page are loading, when you click on a button, etc.

Just explore the codebase add spinners wherever you think is required

Mayank0255 commented 1 year ago

@shravankumar-fs Any progress on this?

amreekminocha commented 1 year ago

Hi.. is anyone working on this issue.. I would like to work on it if no one else is assigned.

Mayank0255 commented 1 year ago

@amreekminocha Ya sure, go ahead.

Any idea how much time will it take you to complete this task?

amreekminocha commented 1 year ago

Thanks for assigning.. I'll go through the project once then i'll tell you the required time

mayank-zoman commented 1 year ago

Thanks for assigning.. I'll go through the project once then i'll tell you the required time

Sure, not an issue

amreekminocha commented 1 year ago

Hi I am having this error Stackoverflow-Clone-Frontend/node_modules/webpack-dev-server/lib/Server.js:348 } catch {

Can you help

Mayank0255 commented 1 year ago

@amreekminocha

Can you pls send me the complete error? I can't firgure out anything from this.

And can you please let me know that did you get this error while setting up the repo or what?

amreekminocha commented 1 year ago

Yes.. I am getting this error while setting the frontend repo

Screenshot 2022-09-29 at 2 45 32 PM
amreekminocha commented 1 year ago

Hi do share a point of contact as well

Mayank0255 commented 1 year ago

Hi do share a point of contact as well

sure, you can reach out to me on discord https://discords.com/bio/p/mayank0255

Mayank0255 commented 1 year ago

Yes.. I am getting this error while setting the frontend repo Screenshot 2022-09-29 at 2 45 32 PM

Can you try installing react-scripts individually and then starting the server?

npm i react-scripts

Mayank0255 commented 1 year ago

@amreekminocha and check on which node version are in currently? It should be above 14, 16 is recommended

amreekminocha commented 1 year ago

This worked.. thanks

amreekminocha commented 1 year ago

Hi Can you share the buttons where the spinner is require

Mayank0255 commented 1 year ago

Hi Can you share the buttons where the spinner is require

So, spinners will be required wherever an api call is going, like when the components of a page are loading, when you click on a button, etc.

Just explore the codebase add spinners wherever you think is required

It's ok if you miss some places

Mayank0255 commented 1 year ago

@amreekminocha how's the progress on this?