Homepage filters, question body and UI change

[BurhanRaja]

Updated to the required Homepage

[vercel[bot]]

Someone is attempting to deploy a commit to a Personal Account owned by @Mayank0255 on Vercel.

@Mayank0255 first needs to authorize it.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
stackoverflow-clone-frontend	✅ Ready (Inspect)	Visit Preview	Jul 10, 2022 at 9:04AM (UTC)

[Mayank0255]

@BurhanRaja Can you please add the tick icon as well in green label?

And the asked timestamp is overflowing from the screen, please check

[Mayank0255]

The filters doesn't seem to be working actually, as I can see posts exceeding the filter, please check

https://stackoverflow-clone-fronten-git-d6a3b5-mayank2aggarwal-gmailcom.vercel.app/

I loved the transition between the results though

[BurhanRaja]

The filters doesn't seem to be working actually, as I can see posts exceeding the filter, please check

https://stackoverflow-clone-fronten-git-d6a3b5-mayank2aggarwal-gmailcom.vercel.app/

I loved the transition between the results though

Yaa sure I will check it. I will get back to you in few hours. Should I commit on this pull request on this branch only or should I change it? Thank you.

[BurhanRaja]

I updated the responsive please check it.

[BurhanRaja]

The filters doesn't seem to be working actually, as I can see posts exceeding the filter, please check

https://stackoverflow-clone-fronten-git-d6a3b5-mayank2aggarwal-gmailcom.vercel.app/

I loved the transition between the results though

I am not able to remove the question from the required filter. I am returning null instead but not able to remove the unwanted questions.

[Mayank0255]

@BurhanRaja Do one thing, revert the changes you did for the filters, will create a separate task for that, you can just ship the UI changes in this PR

[BurhanRaja]

@BurhanRaja Do one thing, revert the changes you did for the filters, will create a separate task for that, you can just ship the UI changes in this PR

One request just give me one or two days I will do it. I will complete it.

[Mayank0255]

@BurhanRaja Sure, go ahead

[BurhanRaja]

Completed as per the requirement.

[Mayank0255]

@BurhanRaja

The filters are working good now, its just that the pagination is not getting updated based on the displayed results, it still based on the total results, because of which this is happening

[BurhanRaja]

Can I hit you with a new Pull request and close this one as there are so many commits on one branch. It will hard for you to merge.

[Mayank0255]

@BurhanRaja it doesn't matter how many commits are there, I will be getting he code of your latest comit in files changed. So, no need to create one more

[BurhanRaja]

@BurhanRaja it doesn't matter how many commits are there, I will be getting he code of your latest comit in files changed. So, no need to create one more

Ok sure, will do on the same branch

[Mayank0255]

@BurhanRaja and take a pull from master, there are some conflicts

[BurhanRaja]

I Did it.

[BurhanRaja]

Now, I am not able to ignore the yarn.lock file from my side

[Mayank0255]

Now, I am not able to ignore the yarn.lock file from my side

Try running on your terminal:

git rm --cached <filepath>

It should unstage yarn.lock

[Mayank0255]

Deploy preview for stackoverflow-clone-frontend ready!

✅ Preview https://stackoverflow-clone-frontend-5thwua2fn-mayank2aggarwal-gmailcom.vercel.app

Built with commit 144f441c026e64f76612ffca6272d8159a47d355. This pull request is being automatically deployed with vercel-action

[BurhanRaja]

Deploy preview for stackoverflow-clone-frontend ready!

✅ Preview https://stackoverflow-clone-frontend-q8bytobo4-mayank2aggarwal-gmailcom.vercel.app

Built with commit e88909f. This pull request is being automatically deployed with [vercel-action]

Deploy preview for stackoverflow-clone-frontend ready!

✅ Preview https://stackoverflow-clone-frontend-q8bytobo4-mayank2aggarwal-gmailcom.vercel.app

Built with commit e88909f. This pull request is being automatically deployed with vercel-action

Do I have to build and deploy?

[Mayank0255]

@BurhanRaja no, you dont, that's an automated message.

And btw pls take a pull from master, there are some conflicts which should be resolved, I won't be able to merge otherwise

[BurhanRaja]

Is there issue with my code or commits? I tried resolving it at best. Is it not yet resolved?

[mayank-zoman]

@BurhanRaja Can you take pull again from master? And resolve the conflicts if found any

[BurhanRaja]

@mayank-zoman Ok so what I will do is I will hit you with another pull request from different branch which has no conflicts this burhanraja has so many conflicts and its increasing, so I will create a new branch.

[mayank-zoman]

@mayank-zoman Ok so what I will do is I will hit you with another pull request from different branch which has no conflicts this burhanraja has so many conflicts and its increasing, so I will create a new branch.

Sure, do that