Closed tgriesser closed 6 years ago
This PR is an attempt to get rid of the errors I'm seeing when using the new description syntax in my GraphQL schema definition file. I've been working the changes on this branch locally and it seems to do the trick.
Merging #111 into master will decrease coverage by
0.77%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 85.98% 85.21% -0.78%
==========================================
Files 54 54
Lines 1320 1305 -15
==========================================
- Hits 1135 1112 -23
- Misses 185 193 +8
Hi @tgriesser thanks for the PR.
But there are few issues with graphql >0.12.x
The proper fix is already in v3 branch (I will try to release it as soon as possible). For now anyone who is using the new description can use your fork to avoid parsing error.
@Mayank1791989 Are you interested in any contributions assisting with the v3 project? Is there any way we can help keep that moving?
@Mayank1791989 Is there any update on v3, sadly the entire GrsaphQL for vscode extension has become rather useless when not being able to use the latest graphql libs. Happy to jump in and help push this thorough just lmk when you need assistance as this is a core dev tool for us which right now does not work since weeks
I just upgraded this to GraphQL 0.13, anyone that needs it can use
"@playlyfe/gql": "tgriesser/gql.git#upgrade-deps-published-0.13",
in their package.json
Nevermind, the changes here seem to break things, couldn't figure out why exactly. I think it might have to do with the fact that the language service is still on ^0.12
?
Anyway, closing this since it's not going to be merged as is.
Looks like there's some good work being done on the graphql-for-vscode related to this. Looking forward to it!
Descriptions are now correctly defined/parsed as quoted strings preceding the node.
ArgumentsOfCorrectType became ValuesOfCorrectType in 0.12
Upgraded dependencies: