search

Mayank1791989 / gql

112 stars 19 forks source link

Add schema and resolvers finder #152

Open darkbasic opened 5 years ago

darkbasic commented 5 years ago

I didn't find any way to initiate a showTextDocument from the server, so for the moment I just show a message to the client with the resolver location: https://github.com/Microsoft/language-server-protocol/issues/612 If we decide that we like the CodeLens approach I could give it a shot and submit a PR to implement it.

darkbasic commented 5 years ago

See also: https://github.com/Mayank1791989/gql-language-server/pull/3 https://github.com/kumarharsh/graphql-for-vscode/pull/131

kumarharsh commented 5 years ago

@darkbasic that is some fantastic work! 👏🏻

darkbasic commented 5 years ago

Forgot to mention the PR on vscode-languageserver-node to enhance the protocol to implement ShowTextDocumentRequest, necessary for Code Lens: https://github.com/microsoft/vscode-languageserver-node/pull/490

RyanzpLee commented 1 year ago

Hey @darkbasic I just wanted to ask if this feature was ever implemented into any other extensions. Seems like a useful feature but looks like it was never released for this extension at least?

darkbasic commented 1 year ago

Hi, unfortunately this is still unreleased work.

RyanzpLee commented 1 year ago

Would it be okay if I try to get this working locally on a extension?

darkbasic commented 1 year ago

Sure, I would love to!

RyanzpLee commented 1 year ago

Sure, I would love to!

Thank you! I have absolutely no experience with any of this but this type of feature would be extremely useful for me in a very large graphql codebase. Hopefully I can manage 😄

darkbasic commented 1 year ago

If you want want an head start back then I made a Youtube video showcasing my work. It probably won't add anything which isn't already covered in this PR, but I'm linking it nevertheless.

RyanzpLee commented 1 year ago

If you want want an head start back then I made a Youtube video showcasing my work. It probably won't add anything which isn't already covered in this PR, but I'm linking it nevertheless.

Thank you for the video! As I understand, this extension was parsing the graphqlrc config and you added a new field called resolvers.

Do you think this feature could also be implemented in the Vscode-graphql as that is a maintained extension? I've had an explanatory investigation to see if it would be possible but I'm not sure how big the scope of work would be to do so.

Do you have any advice on this please?

darkbasic commented 1 year ago

Do you think this feature could also be implemented in the Vscode-graphql as that is a maintained extension

I think so but I cannot be sure until I dig deep into the extension internals.