search

Mayank1791989 / gql

112 stars 19 forks source link

Remove reliance on watchman #62

Open batjko opened 7 years ago

batjko commented 7 years ago

In the interest of reducing annoyance of non-Mac users (especially windows ones), avoiding watchman would be a great boon for this package.

I am not sure what it should be replaced with, but ideally with something built into this package.

Many thanks!

Mayank1791989 commented 7 years ago

This was already added in v3 (will be released soon).

FezVrasta commented 6 years ago

any updates on this?

batjko commented 6 years ago

This was already added in v3 (will be released soon).

What's the schedule for v3?

danielkcz commented 6 years ago

Just want to note here, that with Watchman Beta for Windows it's working just fine. I haven't run into any issues. Personally, I am against removing watchman. It's great tool conserving system resources into a single point instead of having numerous watchers over the same files. At least make it configurable so it's still possible to use Watchman.

Mayank1791989 commented 6 years ago

@FredyC in v3 watchman is not removed. It will use NodeWatcher only if watchman is not present.