Closed kspook closed 5 years ago
@eldon Thanks a lot. I find out that you modified the tools/export_saved_model.py and write a new script named tfserve/export_saved_model.py at the mean time. What's the difference between them? Is it necessary to keep them both?
@eldon Seems like the exported saved model have conflicts. Since I prepare to merge your commit to implement the tensorflow serving function I will remove the old exported saved model of mine and use yours instead. Could you please pull a new request when we finished discussing how to merge the conflicts?
@eldon I have manually merged the conflicts. You may pull and update the code and see if there's something differs from your wish:)
@eldon You may pull a new request to share your docker file with us if you are willing to. Please let me know if you're confused with the newly updates:)
Hi @MaybeShewill-CV thanks for the notes! Let me respond to the questions:
The tools/export_saved_model.py exports the saved model with the output as the sparse tensor (it is the original saved model exporter, in case you don't want to use tf-serving. tfserve/export_saved_model.py breaks apart the output sparse tensor in case you want to use it with the tfserve client. It's your choice whether or not to keep the original under tools, I just left if there in case.
Thanks for helping with the merge! Really appreciate it. I'll merge on my end and create another PR. I don't end up using a dockerfile, but rather the run command which uses google's tfserving image on dockerhub. Cheers,
Btw, thanks @MaybeShewill-CV for the shout-out in the readme! :)
Ah, this file should take care of it, so let's close the PR? Let me know.
https://github.com/MaybeShewill-CV/CRNN_Tensorflow/blob/master/tfserve/run_tfserve_crnn_gpu.sh
@eldon I have closed that PR. You're welcome to pull new request:)
Ok, I think we can leave it as is, it's the same as what I use. :) Cheers
@eldon I will close this issue. Welcome to raise new one:)
@MaybeShewill-CV thank you for your code.
I have error. { "error": "Serving signature name: \"serving_default\" not found in signature def" } How can I solve?
----- script -----------