MaybeShewill-CV / bisenetv2-tensorflow

Unofficial tensorflow implementation of real-time scene image segmentation model "BiSeNet V2: Bilateral Network with Guided Aggregation for Real-time Semantic Segmentation"
https://maybeshewill-cv.github.io/bisenetv2-tensorflow/
MIT License
224 stars 59 forks source link

Performance issues in /data_provider (by P3) #54

Closed DLPerf closed 2 years ago

DLPerf commented 3 years ago

Hello! I've found a performance issue in /data_provider: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.

Detailed description is listed below:

Besides, you need to check the function called in map()(e.g., aug.preprocess_image_for_val called in dataset = dataset.map(map_func=aug.preprocess_image_for_val, num_parallel_calls=CFG.DATASET.CPU_MULTI_PROCESS_NUMS)) whether to be affected or not to make the changed code work properly. For example, if aug.preprocess_image_for_val needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf commented 2 years ago

Hello, I'm looking forward to your reply~